update tests

apache · Mar 29, 2023 · f651879 · f651879
1 parent 85ac0e9
commit f651879
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 13 deletions.
diff --git a/superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx b/superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx
@@ -20,15 +20,25 @@
 import React, { useState } from 'react';
 import userEvent from '@testing-library/user-event';
 import { render, screen } from 'spec/helpers/testing-library';
-import { getMockStoreWithNativeFilters } from 'spec/fixtures/mockStore';
 import chartQueries, { sliceId } from 'spec/fixtures/mockChartQueries';
+import mockState from 'spec/fixtures/mockState';
 import DrillByModal from './DrillByModal';
 
-const { id: chartId, form_data: formData } = chartQueries[sliceId];
+const { form_data: formData } = chartQueries[sliceId];
 const { slice_name: chartName } = formData;
-
-const renderModal = async () => {
-  const store = getMockStoreWithNativeFilters();
+const drillByModalState = {
+  ...mockState,
+  dashboardLayout: {
+    CHART_ID: {
+      id: 'CHART_ID',
+      meta: {
+        chartId: formData.slice_id,
+        sliceName: chartName,
+      },
+    },
+  },
+};
+const renderModal = async (state?: object) => {
   const DrillByModalWrapper = () => {
     const [showModal, setShowModal] = useState(false);
     return (
@@ -37,9 +47,8 @@ const renderModal = async () => {
           Show modal
         </button>
         <DrillByModal
-          chartId={chartId}
           formData={formData}
-          initialFilters={[]}
+          filters={[]}
           showModal={showModal}
           onHideModal={() => setShowModal(false)}
         />
@@ -48,17 +57,18 @@ const renderModal = async () => {
   };
 
   render(<DrillByModalWrapper />, {
-    useRouter: true,
+    useDnd: true,
     useRedux: true,
-    store,
+    useRouter: true,
+    initialState: state,
   });
 
   userEvent.click(screen.getByRole('button', { name: 'Show modal' }));
   await screen.findByRole('dialog', { name: `Drill by: ${chartName}` });
 };
 
 test('should render the title', async () => {
-  await renderModal();
+  await renderModal(drillByModalState);
   expect(screen.getByText(`Drill by: ${chartName}`)).toBeInTheDocument();
 });
 

diff --git a/superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx b/superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx
@@ -66,9 +66,6 @@ export default function DrillByModal({
   onHideModal,
   showModal,
 }: DrillByModalProps) {
-  console.log(column);
-  console.log(formData);
-  console.log(filters);
   const theme = useTheme();
   const dashboardLayout = useSelector<RootState, DashboardLayout>(
     state => state.dashboardLayout.present,
@@ -80,6 +77,7 @@ export default function DrillByModal({
     chartLayoutItem?.meta.sliceName || chartLayoutItem?.meta.sliceNameOverride;
   const exploreChart = () => {};
 
+  console.log(column, filters);
   return (
     <Modal
       css={css`