fix default view mode logic

apache · Nov 16, 2020 · fe8c98a · fe8c98a
1 parent cd7f177
commit fe8c98a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/superset-frontend/src/components/ListView/ListView.tsx b/superset-frontend/src/components/ListView/ListView.tsx
@@ -276,6 +276,7 @@ function ListView<T extends object = any>({
     initialSort,
     initialFilters: filters,
     renderCard: Boolean(renderCard),
+    defaultViewMode,
   });
   const filterable = Boolean(filters.length);
   if (filterable) {

diff --git a/superset-frontend/src/components/ListView/utils.ts b/superset-frontend/src/components/ListView/utils.ts
@@ -133,6 +133,7 @@ interface UseListViewConfig {
     Cell: (conf: any) => React.ReactNode;
   };
   renderCard?: boolean;
+  defaultViewMode?: ViewModeType;
 }
 
 export function useListViewState({
@@ -146,6 +147,7 @@ export function useListViewState({
   bulkSelectMode = false,
   bulkSelectColumnConfig,
   renderCard = false,
+  defaultViewMode = 'card',
 }: UseListViewConfig) {
   const [query, setQuery] = useQueryParams({
     filters: RisonParam,
@@ -171,7 +173,8 @@ export function useListViewState({
   };
 
   const [viewMode, setViewMode] = useState<ViewModeType>(
-    (query.viewMode as ViewModeType) || 'table',
+    (query.viewMode as ViewModeType) ||
+      (renderCard ? defaultViewMode : 'table'),
   );
 
   const columnsWithSelect = useMemo(() => {