Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue while using Forecasting #11106

Closed
kkalyan opened this issue Sep 29, 2020 · 2 comments
Closed

Issue while using Forecasting #11106

kkalyan opened this issue Sep 29, 2020 · 2 comments
Assignees
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@kkalyan
Copy link
Contributor

kkalyan commented Sep 29, 2020

I'm trying to use Prophet forecasting on Druid datasource and it throws the following exception
Unexpected Error
Error: Column ds has timezone specified, which is not supported. Remove timezone.

Expected results

Forecast as illustrated in #10752

Actual results

ValueError: Column ds has timezone specified, which is not supported. Remove timezone.
ERROR:superset.common.query_context:Column ds has timezone specified, which is not supported. Remove timezone.
Traceback (most recent call last):
  File "/local/home/kkanuri/env/lib/python3.6/site-packages/superset/common/query_context.py", line 251, in get_df_payload
    query_result = self.get_query_result(query_obj)
  File "/local/home/kkanuri/env/lib/python3.6/site-packages/superset/common/query_context.py", line 117, in get_query_result
    df = query_object.exec_post_processing(df)
  File "/local/home/kkanuri/env/lib/python3.6/site-packages/superset/common/query_object.py", line 262, in exec_post_processing
    df = getattr(pandas_postprocessing, operation)(df, **options)
  File "/local/home/kkanuri/env/lib/python3.6/site-packages/superset/utils/pandas_postprocessing.py", line 672, in prophet
    freq=freq,
  File "/local/home/kkanuri/env/lib/python3.6/site-packages/superset/utils/pandas_postprocessing.py", line 602, in _prophet_fit_and_predict
    model.fit(df)
  File "/local/home/kkanuri/env/lib/python3.6/site-packages/fbprophet/forecaster.py", line 1111, in fit
    history = self.setup_dataframe(history, initialize_scales=True)
  File "/local/home/kkanuri/env/lib/python3.6/site-packages/fbprophet/forecaster.py", line 265, in setup_dataframe
    'Column ds has timezone specified, which is not supported. '
ValueError: Column ds has timezone specified, which is not supported. Remove timezone.

Screenshots

How to reproduce the bug

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Environment

(please complete the following information):

  • superset version: superset version - 0.37.2
  • python version: python --version 3.6.9
  • node.js version: node -v
  • npm version: npm -v

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • [x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [x ] I have reproduced the issue with at least the latest released version of superset.
  • [x ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

@villebro

@kkalyan kkalyan added the !deprecated-label:bug Deprecated label - Use #bug instead label Sep 29, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.88. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

kkalyan added a commit to kkalyan/incubator-superset that referenced this issue Sep 29, 2020
While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info. 
ValueError: Column ds has timezone specified, which is not supported. Remove timezone
apache#11106

@villebro
@junlincc
Copy link
Member

@kkalyan Thanks for reporting and contributing!!!

villebro added a commit that referenced this issue Sep 30, 2020
* fix: Disabling timezone of dataframe before passing Prophet 

While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info. 
ValueError: Column ds has timezone specified, which is not supported. Remove timezone
#11106

@villebro

* Update pandas_postprocessing.py

* Update superset/utils/pandas_postprocessing.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@kkalyan kkalyan closed this as completed Oct 1, 2020
dpgaspar pushed a commit that referenced this issue Oct 1, 2020
* fix: Disabling timezone of dataframe before passing Prophet 

While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info. 
ValueError: Column ds has timezone specified, which is not supported. Remove timezone
#11106

@villebro

* Update pandas_postprocessing.py

* Update superset/utils/pandas_postprocessing.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
auxten pushed a commit to auxten/incubator-superset that referenced this issue Nov 20, 2020
…1107)

* fix: Disabling timezone of dataframe before passing Prophet 

While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info. 
ValueError: Column ds has timezone specified, which is not supported. Remove timezone
apache#11106

@villebro

* Update pandas_postprocessing.py

* Update superset/utils/pandas_postprocessing.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

3 participants