Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up db_engine_specs and add type hints #7412

Closed
khtruong opened this issue Apr 30, 2019 · 1 comment · Fixed by #7676
Closed

Break up db_engine_specs and add type hints #7412

khtruong opened this issue Apr 30, 2019 · 1 comment · Fixed by #7676
Labels
enhancement:request Enhancement request submitted by anyone from the community

Comments

@khtruong
Copy link
Contributor

Is your feature request related to a problem? Please describe.
db_engine_specs has gotten large and should be broken up in multiple files. The class is also not completely typed.

Describe the solution you'd like
There should be a file for each engine spec and the file should be typed.
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the enhancement:request Enhancement request submitted by anyone from the community label Apr 30, 2019
@khtruong khtruong mentioned this issue Apr 30, 2019
Merged
6 tasks
@villebro villebro mentioned this issue Jun 8, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Break up db_engine_specs
1 participant
@khtruong