-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break up db_engine_specs #7676
Break up db_engine_specs #7676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I was thinking about making this same change. There's one small comment but overall LGTM.
Codecov Report
@@ Coverage Diff @@
## master #7676 +/- ##
==========================================
+ Coverage 65.58% 65.71% +0.12%
==========================================
Files 437 459 +22
Lines 21797 21873 +76
Branches 2403 2403
==========================================
+ Hits 14295 14373 +78
+ Misses 7381 7379 -2
Partials 121 121
Continue to review full report at Codecov.
|
Thanks for the quick comments @john-bodley, this should now be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - merge quick or conflict soon!
Pushing merge button in a few hours if no objections to avoid painful rebasing (already had 3 conflicts since initial commit). |
This is awesome. Thanks so much for this! |
CATEGORY
Choose one
SUMMARY
This PR changes
db_engine_specs.py
into a package with one module per engine, e.g.db_engine_specs/bigquery.py
. All engines are automatically populated intodb_engine_specs.engines
like before (now indb_engine_specs/__init__.py
), so only importing of specific engine specs will need to be changed:Before:
from superset.db_engine_specs import BaseEngineSpec
After:
from superset.db_engine_specs.base import BaseEngineSpec
TEST PLAN
Local testing + CI
ADDITIONAL INFORMATION
REVIEWERS
@khtruong @john-bodley @betodealmeida @mistercrunch