Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log config errors #8004

Closed
micimize opened this issue Aug 7, 2019 · 2 comments
Closed

Log config errors #8004

micimize opened this issue Aug 7, 2019 · 2 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community

Comments

@micimize
Copy link
Contributor

micimize commented Aug 7, 2019

Problem:
If there is any error while attempting to load the config, it is ignored and the error is swallowed. This makes it needlessly difficult to debug errors.

Solution:
Log the errors, and maybe provide a runtime option to abort startup if the config loading fails.

Additional context
I'd guess that ignoring a buggy config and starting up anyways is not a valuable behavior in most scenarios

@issue-label-bot issue-label-bot bot added the enhancement:request Enhancement request submitted by anyone from the community label Aug 7, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.74. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@micimize
Copy link
Contributor Author

micimize commented Aug 7, 2019

Relatedly, this makes the hot reload behavior when a config has an error:

  • ignore the config and reload
  • stop watching the config for changes because it's no longer part of the app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Development

No branches or pull requests

1 participant