Local config no longer fails to import silently #8006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superset/config.py
Outdated
| for key in dir(override_conf): | ||
| if key.isupper(): | ||
| setattr(module, key, getattr(override_conf, key)) | ||
|
|
||
| else: | ||
| print("Loaded your LOCAL configuration at [{}]".format(cfg_path)) |
There was a problem hiding this comment.
Nit: can you update this to use f-strings? Superset no longer supports Python < 3.6.
superset/config.py
Outdated
| print("Loaded your LOCAL configuration at [{}]".format(cfg_path)) | ||
| except Exception: | ||
| logging.exception( | ||
| "Failed to import config for {}={}".format(CONFIG_PATH_ENV_VAR, cfg_path) |
There was a problem hiding this comment.
Nit: same here, using f-strings.
superset/config.py
Outdated
| except ImportError: | ||
| pass | ||
| except Exception: | ||
| logging.exception("Failed to import local superset_confg") |
|
closes #8004 |
|
@betodealmeida @mistercrunch et al... can someone kick the CI, it looks like some sporadic, unrelated issues caused it to fail. |
mistercrunch
approved these changes
Aug 8, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Previously, local superset_config or configured (via env) file could fail to import and superset would swallow the error and continue to run. Now, if user has provided a path or a superset_config.py and it fails to import, the exception will be clearly logged and re-raised causing superset to stop immediately.
TEST PLAN
Manually tested with both forms of config (env and superset_config), with and without various errors.
ADDITIONAL INFORMATION
REVIEWERS
@betodealmeida @mistercrunch @john-bodley