fix: refine shouldUseLegacyApi and add tests #10148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
reviewed
Jun 24, 2020
| getChartMetadataRegistry().remove('my_legacy_viz').remove('my_v1_viz'); | ||
| }); | ||
|
|
||
| it('return true for legacy viz', () => { |
There was a problem hiding this comment.
NIT, but maybe "returns" for these so it('reads like a sentence')
|
@rusackas thanks for nittery, comments addressed! |
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix: refine shouldUseLegacyApi and add tests * address review comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The bug that #10147 fixes exposed a shortcoming in the
shouldUseLegacyApifunction inexploreUtils. This fixes the bug and adds unit tests to catch all possible cases I could think of.TEST PLAN
CI + new tests
ADDITIONAL INFORMATION