fix: excel sheet upload is not working

[pphszx]

SUMMARY

The new excel sheet upload feature is not working, this issue is reported in #9825 (comment), this PR fixes it with come changes specific to pandas.read_excel.

e.g. args of chunksize, skipinitialspace are not supported, parse_dates is supported by both, filename arg is io, not filepath_or_buffer, which is for read_csv. sheet_name could be string, but integer should be more common.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[villebro]

Thanks @pphszx for the fix! The security manager methods were probably renamed while the original Excel upload PR was under review, hence this error sneaked in. See @10031 for details.

Are all the changes here necessary for making this work? If possible, I'd prefer to keep the changes to a minimum, and then follow up with a cleanup PR to add robustness. Not sure if you're aware, but we'll be releasing 0.37.0 soon, and it would be great to get this feature working for that release.

Ping @blcksrx : as you have most context, you're probably the best person to review this PR.

[blcksrx]

As @villebro mentioned above, I'd prefer to keep changes to be minimum.

[pphszx]

Hi @villebro, @blcksrx, I've add comments to all my changes, you can decide which part can be removed. You are free to change, just make this feature work on 0.37.0. Thanks!

[blcksrx]

@pphszx Thanks for the description. I did read them all and still disagree with changing the sheet_name type from string to integer. what's your idea @villebro?

[bkyryliuk]

General suggestion, let's add unit test to prevent regressions like this

[villebro]

Left a few comments. I'd also encourage adding a unit test as @bkyryliuk suggested, but understand it may be tricky due to the file format (one would probably need to programmatically generate an Excel file and then try to upload that with different variations of input values, asserting that the resulting table metadata is correct).

[villebro]

LGTM, thanks for cleaning this up! @blcksrx are you ok with these changes?

[blcksrx]

@villebro Yeah. I'm okay with that