Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable false positive error #10576

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

dpgaspar
Copy link
Member

SUMMARY

Disables a false positive error

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

Codecov Report

Merging #10576 into master will increase coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10576      +/-   ##
==========================================
+ Coverage   59.56%   59.68%   +0.12%     
==========================================
  Files         767      767              
  Lines       36268    36314      +46     
  Branches     3426     3431       +5     
==========================================
+ Hits        21603    21675      +72     
+ Misses      14472    14447      -25     
+ Partials      193      192       -1     
Flag Coverage Δ
#javascript 59.87% <ø> (-0.03%) ⬇️
#python 59.57% <0.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/decorators.py 55.00% <0.00%> (ø)
...-frontend/src/dashboard/reducers/dashboardState.js 74.54% <0.00%> (-2.82%) ⬇️
...d/src/dashboard/components/gridComponents/Tabs.jsx 68.42% <0.00%> (-2.82%) ⬇️
superset/common/query_context.py 82.50% <0.00%> (-2.76%) ⬇️
...tend/src/dashboard/components/DashboardBuilder.jsx 77.27% <0.00%> (-2.42%) ⬇️
superset/models/alerts.py 95.23% <0.00%> (-2.39%) ⬇️
superset/connectors/sqla/models.py 89.19% <0.00%> (-1.09%) ⬇️
superset/tasks/schedules.py 73.23% <0.00%> (-0.93%) ⬇️
superset/security/manager.py 90.00% <0.00%> (-0.65%) ⬇️
superset/viz.py 57.52% <0.00%> (-0.39%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0db0d...bf2506c. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dpgaspar dpgaspar merged commit b7650b9 into apache:master Aug 11, 2020
@dpgaspar dpgaspar deleted the fix/false-positive-error branch August 11, 2020 17:21
villebro pushed a commit to preset-io/superset that referenced this pull request Aug 20, 2020
craig-rueda pushed a commit to preset-io/superset that referenced this pull request Aug 24, 2020
villebro pushed a commit that referenced this pull request Sep 5, 2020
villebro pushed a commit that referenced this pull request Sep 16, 2020
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 0.37.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.37 v0.37.2 🍒 0.37.2 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants