Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix indentation issue #10690

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Conversation

john-bodley
Copy link
Member

SUMMARY

Fixing an indentation issue (I suspect pylint would find this is configured correctly) whilst reading through the code. The extra_filters variable is not defined in the parent scope.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #10690 into master will decrease coverage by 4.85%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10690      +/-   ##
==========================================
- Coverage   64.37%   59.51%   -4.86%     
==========================================
  Files         785      360     -425     
  Lines       36987    23184   -13803     
  Branches     3530        0    -3530     
==========================================
- Hits        23810    13799   -10011     
+ Misses      13068     9385    -3683     
+ Partials      109        0     -109     
Flag Coverage Δ
#cypress ?
#javascript ?
#python 59.51% <100.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/tasks/cache.py 73.91% <100.00%> (ø)
superset/db_engine_specs/mysql.py 79.16% <0.00%> (-12.50%) ⬇️
superset/db_engine_specs/presto.py 70.91% <0.00%> (-11.41%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 97.36% <0.00%> (-2.64%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 86.38% <0.00%> (-1.12%) ⬇️
superset/connectors/sqla/models.py 89.45% <0.00%> (-0.28%) ⬇️
superset/views/core.py 74.26% <0.00%> (-0.25%) ⬇️
...-frontend/src/dashboard/containers/FilterScope.jsx
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0fc4e...5541016. Read the comment docs.

Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@john-bodley john-bodley merged commit 8581bda into master Aug 27, 2020
@john-bodley john-bodley deleted the john-bodley--fix-indentation branch August 27, 2020 03:41
@villebro villebro added the v0.38 label Sep 10, 2020
villebro pushed a commit to preset-io/superset that referenced this pull request Sep 11, 2020
villebro pushed a commit that referenced this pull request Sep 11, 2020
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.38 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants