-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix indentation issue #10690
chore: Fix indentation issue #10690
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10690 +/- ##
==========================================
- Coverage 64.37% 59.51% -4.86%
==========================================
Files 785 360 -425
Lines 36987 23184 -13803
Branches 3530 0 -3530
==========================================
- Hits 23810 13799 -10011
+ Misses 13068 9385 -3683
+ Partials 109 0 -109
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, @dpgaspar found something similar in https://github.com/apache/incubator-superset/pull/10576/files
SUMMARY
Fixing an indentation issue (I suspect
pylint
would find this is configured correctly) whilst reading through the code. Theextra_filters
variable is not defined in the parent scope.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
CI.
ADDITIONAL INFORMATION