chore: Using cache factory method #10887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Sep 15, 2020
| @@ -24,28 +24,24 @@ class CacheManager: | |||
| def __init__(self) -> None: | |||
| super().__init__() | |||
|
|
|||
| self._tables_cache = None | |||
| self._cache = None | |||
There was a problem hiding this comment.
It's interesting that the
@property
def cache(self) -> Cache:
return self._cachemethod didn't barf from a MyPy perspective given that self._cache is actually Optional[Cache] per the definition on line 28.
john-bodley
force-pushed
the
john-bodley--cache-factory-method
branch
from
c573cb9 to
5f25d09
Compare
john-bodley
force-pushed
the
john-bodley--cache-factory-method
branch
from
5f25d09 to
dc79c53
Compare
john-bodley
force-pushed
the
john-bodley--cache-factory-method
branch
from
dc79c53 to
d3eea2c
Compare
craig-rueda
approved these changes
Sep 15, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com>
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Switching the cache manager to use the factory method which allows the cache to be used within blueprints et al. prior to being bound to the application. This approach is also a step in the preferred direction, i.e., away from the legacy configuration defined here.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
CI.
ADDITIONAL INFORMATION