fix: simply is_adhoc_metric #10964
Merged
fix: simply is_adhoc_metric #10964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
reviewed
Sep 20, 2020
superset/utils/core.py
Outdated
| ) | ||
| and metric.get("label") | ||
| ) | ||
| if isinstance(metric, dict): |
There was a problem hiding this comment.
nit: you can just return isinstance(metric, dict)
dpgaspar
approved these changes
Sep 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #10964 +/- ##
=======================================
Coverage 65.80% 65.80%
=======================================
Files 815 815
Lines 38327 38324 -3
Branches 3600 3600
=======================================
- Hits 25221 25220 -1
+ Misses 13002 13000 -2
Partials 104 104
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ranjitpatra
added a commit
to ranjitpatra/incubator-superset
that referenced
this pull request
Sep 20, 2020
fix: simply is_adhoc_metric (apache#10964)
villebro
added a commit
that referenced
this pull request
Sep 21, 2020
* fix: simply is_adhoc_metric * address comment
dpgaspar
pushed a commit
that referenced
this pull request
Sep 22, 2020
* fix: simply is_adhoc_metric * address comment
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 22, 2020
…l_access/dashboard_by_id_endpoints * upstream/master: (29 commits) fix(presto): default unknown types to string type (apache#10753) feat(row-level-security): add base filter type and filter grouping (apache#10946) docs: add gallery screenshot & link in README (apache#10988) docs: add a "Gallery" page (apache#10968) build: add PR lint action (apache#10990) adding filters back that caused issues (apache#10989) chore: selectors refactor in SQLLab test suite (Cypress) (apache#10944) ESLint: Remove ts-ignore comments (apache#10933) style: fix checkbox color (apache#10970) fix: changed disabled rules in datasets module (apache#10979) fix: update the time filter for 'Last Year' option in explore (apache#10829) fix: use nullpool even for user lookup in the celery (apache#10938) Allow empty observations in alerting (apache#10939) fix: re-enabling several globally disabled lint rules (apache#10957) fix: setting specific exceptions common/query_context.py (apache#10942) Pylint disabled rule `pointless-string-statement` is not raising warining anymore - removing (apache#10975) fix: pylint disabled rules in dashboard/api.py (apache#10976) fix: removed disabled lint rule `too-many-locals` in connectors/base/models.py (apache#10958) ESLint: Re-enable rule no-access-state-in-setstate (apache#10870) fix: simply is_adhoc_metric (apache#10964) ...
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix: simply is_adhoc_metric * address comment
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fix: simply is_adhoc_metric * address comment
mistercrunch
added
🍒 0.37.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the
is_adhoc_metricutility function checks can fail for a metric that has been defined with{"expressionType": "SIMPLE", "aggregate": None}, which is supported by certain analytical databases and works on Superset 0.36.0 but not 0.37.x. In the future we should introduceTypedDictto enforce these datastructures, perform a migration on the chart metadata to ensure all metadata is compliant (potentially even introduce a metadata data quality checker) and make the metric modal more strict about what types of aggregation options are possible.TEST PLAN
ADDITIONAL INFORMATION