Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert #10868 to fix dashboard tab switch #11050

Merged
merged 1 commit into from
Sep 24, 2020
Merged

fix: Revert #10868 to fix dashboard tab switch #11050

merged 1 commit into from
Sep 24, 2020

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Sep 24, 2020 •
edited
Loading

Reverts #10868 to fix dashboard tab switch.

please see discussion in #10868

@etr2460 @rusackas @kgabryje

github-actions[bot]
github-actions bot previously requested changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format your PR title to match: ^(build|chore|ci|docs|feat|fix|perf|refactor|style|test|other)((.+))?:\s.+!

@graceguo-supercat graceguo-supercat changed the title Revert "ESLint: Re-enable rule default-props-match-prop-types" fix: Revert "ESLint: Re-enable rule default-props-match-prop-types" to fix dashboard tab switch Sep 24, 2020
@graceguo-supercat graceguo-supercat changed the title fix: Revert "ESLint: Re-enable rule default-props-match-prop-types" to fix dashboard tab switch fix: Revert #10868 to fix dashboard tab switch Sep 24, 2020
@etr2460 etr2460 merged commit f99753a into master Sep 24, 2020
@kgabryje kgabryje mentioned this pull request Sep 25, 2020
Merged
6 tasks
amitmiran137 pushed a commit to ofekisr/incubator-superset that referenced this pull request Sep 27, 2020
Merge remote-tracking branch 'upstream/master' into feat/add_all_dash…
63c3295 
…boards_permissions

* upstream/master: (46 commits)
  fix: surface connection error messages on the client (apache#11077)
  fix(jest): using UTC mock date (apache#11079)
  removing unused component (apache#11072)
  changing to the correct hex color (apache#11073)
  style: remove unecessary padding (apache#11071)
  fix: database list checkboxes (apache#11068)
  feat: adding all icons from the design system to the codebase (apache#11033)
  fix: sql lab autocomplete width (apache#11063)
  clickable labels have outlines, storybook shows them (apache#11034)
  fixed routes for customer in docs (apache#11052)
  Revert "style: fix checkbox color (apache#10970)" (apache#11051)
  feat: add "created by" to dashboard CRUD view (apache#11030)
  Changed `tags.py` and `helpers.py` in `models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument. Removed redundant rules.` (apache#11037)
  chore: updated lint rules in models module (apache#11036)
  Removed disable global pytlint rule `standarderror-builtin` which isn't appearing for Python3 (apache#11038)
  Enabled argument-differ for bulk_delete (apache#11039)
  Enabled no-self-use pylint rule in security. Formatter (apache#11041)
  Changed variable name from capitals to lowercase and changed lint rule (apache#11044)
  Revert "ESLint: Re-enable rule default-props-match-prop-types (apache#10868)" (apache#11050)
  feat(saved_queries): add custom api filter for all string & text fields (apache#11031)
  ...

# Conflicts:
#	superset/config.py
#	tests/dashboards/api_tests.py
amitmiran137 pushed a commit to ofekisr/incubator-superset that referenced this pull request Sep 27, 2020
Merge remote-tracking branch 'upstream/master' into feat/add_all_dash…
1ee44c2 
…boards_permissions

* upstream/master: (46 commits)
  fix: surface connection error messages on the client (apache#11077)
  fix(jest): using UTC mock date (apache#11079)
  removing unused component (apache#11072)
  changing to the correct hex color (apache#11073)
  style: remove unecessary padding (apache#11071)
  fix: database list checkboxes (apache#11068)
  feat: adding all icons from the design system to the codebase (apache#11033)
  fix: sql lab autocomplete width (apache#11063)
  clickable labels have outlines, storybook shows them (apache#11034)
  fixed routes for customer in docs (apache#11052)
  Revert "style: fix checkbox color (apache#10970)" (apache#11051)
  feat: add "created by" to dashboard CRUD view (apache#11030)
  Changed `tags.py` and `helpers.py` in `models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument. Removed redundant rules.` (apache#11037)
  chore: updated lint rules in models module (apache#11036)
  Removed disable global pytlint rule `standarderror-builtin` which isn't appearing for Python3 (apache#11038)
  Enabled argument-differ for bulk_delete (apache#11039)
  Enabled no-self-use pylint rule in security. Formatter (apache#11041)
  Changed variable name from capitals to lowercase and changed lint rule (apache#11044)
  Revert "ESLint: Re-enable rule default-props-match-prop-types (apache#10868)" (apache#11050)
  feat(saved_queries): add custom api filter for all string & text fields (apache#11031)
  ...

# Conflicts:
#	superset/config.py
#	tests/dashboards/api_tests.py
rorymillersoft referenced this pull request in nets-aric/incubator-superset Oct 28, 2020
@rorymillersoft
Merge commit 'c14a06db4185b9b043116708b649b0be2ad17a1f' into superset…
1ac9518 
…_additions

* commit 'c14a06db4185b9b043116708b649b0be2ad17a1f':
  Revert "style: fix checkbox color (#10970)"
  feat: add "created by" to dashboard CRUD view (#11030)
  Changed `tags.py` and `helpers.py` in `models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument. Removed redundant rules.` (#11037)
  chore: updated lint rules in models module (#11036)
  Removed disable global pytlint rule `standarderror-builtin` which isn't appearing for Python3 (#11038)
  Enabled argument-differ for bulk_delete (#11039)
  Enabled no-self-use pylint rule in security. Formatter (#11041)
  Changed variable name from capitals to lowercase and changed lint rule (#11044)
  Revert "ESLint: Re-enable rule default-props-match-prop-types (#10868)" (#11050)
  feat(saved_queries): add custom api filter for all string & text fields (#11031)
  Support jinja templates (#11008)
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@auxten
Revert "ESLint: Re-enable rule default-props-match-prop-types (apache…
8fc6957 
…#10868)" (apache#11050)

This reverts commit 9f01a7f.
@amitmiran137 amitmiran137 deleted the revert-10868-eslint/default-props-match-prop-types branch March 29, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

@github-actions GitHub Actions github-actions left review comments

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graceguo-supercat @etr2460