feat(charts): modify custom api filter to include more fields #11054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
force-pushed
the
tai/custom-filter-chart
branch
2 times, most recently
from
a171849
to
1ae8278
Compare
nytai
force-pushed
the
tai/custom-filter-chart
branch
from
1ae8278
to
bb23780
Compare
Codecov Report
@@ Coverage Diff @@
## master #11054 +/- ##
==========================================
+ Coverage 65.79% 73.04% +7.25%
==========================================
Files 816 433 -383
Lines 38422 14236 -24186
Branches 3621 3621
==========================================
- Hits 25280 10399 -14881
+ Misses 13034 3728 -9306
- Partials 108 109 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nytai
commented
Sep 25, 2020
| @@ -364,7 +364,7 @@ function ChartList(props: ChartListProps) { | |||
| Header: t('Search'), | |||
| id: 'slice_name', | |||
| input: 'search', | |||
| operator: 'name_or_description', | |||
| operator: 'chart_all_text', | |||
There was a problem hiding this comment.
Looks like arg_names share a global namespace? I got a test failure on the previously added all_text filter for saved queries. If so, we should add the the resource name to other custom filters so there's no confusion/collision.
dpgaspar
approved these changes
Sep 27, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
similar to #11031 this PR expends the 'search' fields to include slice_name, description, viz_type, or datasource_name
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI, unit tests
ADDITIONAL INFORMATION