Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts/reports): add refresh action #12071

Merged
merged 7 commits into from
Dec 17, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Dec 16, 2020

SUMMARY

  • Adds refresh info the alerts/reports list view
  • Adds refresh action to alerts/reports list view

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
Screen Shot 2020-12-16 at 1 25 57 AM
Screen Shot 2020-12-16 at 1 38 55 AM

TEST PLAN

  • Unit tested
  • manual testing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #12071 (c139908) into master (a3be325) will decrease coverage by 3.24%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12071      +/-   ##
==========================================
- Coverage   66.62%   63.37%   -3.25%     
==========================================
  Files         962      963       +1     
  Lines       47368    47385      +17     
  Branches     4629     4631       +2     
==========================================
- Hits        31557    30030    -1527     
- Misses      15684    17171    +1487     
- Partials      127      184      +57     
Flag Coverage Δ
cypress ?
javascript 62.77% <94.28%> (+0.05%) ⬆️
python 63.73% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/views/CRUD/alert/AlertList.tsx 76.80% <85.71%> (+0.32%) ⬆️
...rset-frontend/src/components/LastUpdated/index.tsx 96.00% <96.00%> (ø)
superset-frontend/src/components/Menu/SubMenu.tsx 100.00% <100.00%> (ø)
superset-frontend/src/views/CRUD/hooks.ts 51.89% <100.00%> (-4.73%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3be325...c139908. Read the comment docs.

@nytai nytai marked this pull request as ready for review December 17, 2020 00:01
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the quick inquiry responses. Thanks for the folderized component too! Not sure if a Storybook entry is really needed, but maybe some rainy day we can sweep through and add them for all components.

@nytai
Copy link
Member Author

nytai commented Dec 17, 2020

@rusackas thanks for the review! I just updated the typing to use MomentInput for lastUpdated prop, should make things as flexible as they can be. Happy to add a storybook entry in a follow up PR

@nytai nytai merged commit d1dfe82 into apache:master Dec 17, 2020
@nytai nytai deleted the tai/alert-refresh branch December 17, 2020 19:29
amitmiran137 pushed a commit to simcha90/incubator-superset that referenced this pull request Dec 18, 2020
* upstream/master: (55 commits)
  feat(explore): time picker enhancement (apache#11418)
  feat: update alert/report icons and column order (apache#12081)
  feat(explore): metrics and filters controls redesign (apache#12095)
  feat(alerts/reports): add refresh action (apache#12071)
  chore: add latest tag action (apache#11148)
  fix(reports): increase crontab size and alert fixes (apache#12056)
  Small typo fix in Athena connection docs (apache#12099)
  feat(queries): security perm simplification (apache#12072)
  feat(databases): security perm simplification (apache#12036)
  feat(dashboards): security permissions simplification (apache#12012)
  feat(logs): security permissions simplification (apache#12061)
  chore: Remove unused CodeModal (apache#11972)
  Fix typescript error (apache#12074)
  fix: handle context-dependent feature flags in CLI (apache#12088)
  fix: Fix "View in SQLLab" bug (apache#12086)
  feat(alert/report): add 'not null' condition option to modal (apache#12077)
  bumping superset ui to 15.18 and deckgl to 0.3.2 (apache#12078)
  fix: Python dependencies in apache#11499 (apache#12079)
  reset active tab on open (apache#12048)
  fix: improve import flow UI/UX (apache#12070)
  ...
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants