Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add visibility to box for viewing menu items #12153

Merged
merged 4 commits into from
Jan 6, 2021
Merged

fix: Add visibility to box for viewing menu items #12153

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cf8134
Add visibility to box for viewing menu items
maloun96 Dec 21, 2020
9ad5f91
Merge branch 'master' of https://github.com/apache/incubator-superset…
maloun96 Dec 22, 2020
fc8fb5f
Add scroll visibility
maloun96 Jan 4, 2021
573ab6e
Merge branch 'master' of https://github.com/apache/incubator-superset…
maloun96 Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset-frontend/src/dashboard/stylesheets/components/chart.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
background-color: @lightest;
position: relative;
padding: 16px;
overflow-y: auto;
overflow-y: visible;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this change will affect Region Filter:
overflow-y: visible (now):
Screenshot 2021-01-04 at 16 15 00

and overflow-y: auto (was):
Screenshot 2021-01-04 at 16 14 46

I changed scroll solution back here but I believe there must be some better solution here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kapture 2021-01-04 at 19 20 42
@kkucharc @junlincc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkucharc I just pulled this, and confirm that what I see looks like @maloun96 's video above. While the scrolling is... weird, it seems comparable to what was there before. I think we're OK, though I hope to find a better design solution to tiny charts/filters like this, as the scrolling is goofy.

I think we're OK here, but let me know if you see any remaining issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally fine with that :) Thank you for double checking! 👍


// transitionable traits for when a filter is being actively focused
transition: opacity 0.2s, border-color 0.2s, box-shadow 0.2s;
Expand Down