Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix styles and add algolia search classes #12267

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jan 5, 2021

SUMMARY

  1. add search classes for algolia serach
  2. update default styles of menu component to superset brand color.
  3. update media query styles to keep images and font inside container on mobile view.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Documentation
Getting Set Up
C Superset tlo-world 1 0

TEST PLAN

Visual manual qa testing of new css.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@pkdotson pkdotson changed the title docs: fix styles and add angolia search classes docs: fix styles and add algolia search classes Jan 5, 2021
@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #12267 (f4f86df) into master (9eb911d) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12267      +/-   ##
==========================================
- Coverage   67.14%   66.95%   -0.19%     
==========================================
  Files        1002     1002              
  Lines       49300    49300              
  Branches     5010     5010              
==========================================
- Hits        33104    33011      -93     
- Misses      16071    16164      +93     
  Partials      125      125              
Flag Coverage Δ
cypress 51.44% <ø> (ø)
javascript 61.20% <ø> (ø)
python 63.84% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/models/core.py 85.86% <0.00%> (-2.99%) ⬇️
superset/views/core.py 72.89% <0.00%> (-2.48%) ⬇️
superset/datasets/api.py 89.44% <0.00%> (-1.84%) ⬇️
superset/db_engine_specs/base.py 84.27% <0.00%> (-1.81%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb911d...f4f86df. Read the comment docs.

@mistercrunch mistercrunch merged commit 321444b into apache:master Jan 11, 2021
@villebro villebro deleted the docs-addsearch branch January 12, 2021 12:23
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
* fix styles and add angolia search classes

* add class

* fix black
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants