Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): prefix class names on events actions #12354

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jan 8, 2021

SUMMARY

Event action property on ModelRestApi custom methods were being logged with just post or put etc... losing the context to where was this post, put generated from. Simple PR that solves this the same way that was already being done on BaseSupersetModelRestApi

Event actions now gets logged with ChartRestApi.put ChartRestApi.favorite_status, DashboardRestApi.put etc..

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #12354 (f0a70c9) into master (c685c9e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12354   +/-   ##
=======================================
  Coverage   62.81%   62.82%           
=======================================
  Files        1014     1014           
  Lines       49496    49504    +8     
  Branches     5070     5066    -4     
=======================================
+ Hits        31092    31101    +9     
+ Misses      18195    18194    -1     
  Partials      209      209           
Flag Coverage Δ
javascript 60.69% <ø> (+0.01%) ⬆️
python 64.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/annotation_layers/api.py 83.19% <100.00%> (ø)
superset/charts/api.py 81.51% <100.00%> (+0.05%) ⬆️
superset/css_templates/api.py 95.74% <100.00%> (ø)
superset/dashboards/api.py 86.63% <100.00%> (+0.05%) ⬆️
superset/databases/api.py 92.01% <100.00%> (+0.03%) ⬆️
superset/datasets/api.py 91.32% <100.00%> (+0.03%) ⬆️
...nd/src/explore/components/ExploreViewContainer.jsx 2.58% <0.00%> (-0.02%) ⬇️
...set-frontend/src/dashboard/util/injectCustomCss.js 91.66% <0.00%> (ø)
...et-frontend/src/components/TableView/TableView.tsx 83.33% <0.00%> (ø)
.../src/components/dataViewCommon/TableCollection.tsx 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c685c9e...f0a70c9. Read the comment docs.

@dpgaspar dpgaspar merged commit 0f731f2 into apache:master Jan 12, 2021
@dpgaspar dpgaspar deleted the fix/event-rest-namespace branch January 12, 2021 10:52
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
* fix(api): prefix class names on events actions

* fix bulk delete
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants