Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add cancel-workflow-runs action locally #12394

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Jan 10, 2021

SUMMARY

Follow up with #12241 #12090 . The "Cancel Workflow Runs" action also needs to be included locally.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

Expect CI runs and previous runs successfully cancelled.

ADDITIONAL INFORMATION

  • Has associated issue: see description
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 10, 2021

Codecov Report

Merging #12394 (cb2149d) into master (f13f2e2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12394      +/-   ##
==========================================
- Coverage   66.88%   66.87%   -0.01%     
==========================================
  Files        1014     1014              
  Lines       49528    49528              
  Branches     5074     5074              
==========================================
- Hits        33125    33122       -3     
- Misses      16273    16276       +3     
  Partials      130      130              
Flag Coverage Δ
cypress 50.92% <ø> (-0.01%) ⬇️
javascript 60.70% <ø> (ø)
python 64.20% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/dashboard/util/getDropPosition.js 92.06% <0.00%> (-1.59%) ⬇️
superset/db_engine_specs/presto.py 82.68% <0.00%> (-0.65%) ⬇️
...ntend/src/dashboard/components/PropertiesModal.jsx 83.03% <0.00%> (ø)
...rset-frontend/src/explore/components/SaveModal.tsx 91.76% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13f2e2...cb2149d. Read the comment docs.

@ktmud
Copy link
Member Author

ktmud commented Jan 13, 2021

Merging since this does not impact any real code and current base obviously is broken.

@ktmud ktmud merged commit 5fe4173 into apache:master Jan 13, 2021
@ktmud ktmud deleted the local-cancel-duplicates branch January 13, 2021 06:11
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants