-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: uneven list header padding (#12029) #12412
fix: uneven list header padding (#12029) #12412
Conversation
superset-frontend/src/components/dataViewCommon/TableCollection.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/components/dataViewCommon/TableCollection.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #12412 +/- ##
==========================================
- Coverage 66.81% 62.76% -4.05%
==========================================
Files 1015 1015
Lines 49544 49530 -14
Branches 5080 5080
==========================================
- Hits 33102 31088 -2014
- Misses 16312 18233 +1921
- Partials 130 209 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tested - No issues found |
65bc2e1
to
ee22c4a
Compare
ee22c4a
to
3eccbe3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nytai please take a look since we touched your area.
NOTE
- This is only Product and QA approval with NO code reviews
- This approval indicates that all UI changes meet product requirement, no noticeable regression is introduced
- This approval indicates this PR is ready for code reviews
Code looks good to me. Tempted to do the usual nag about I'd merge this, but would love to have @nytai's nod of approval first :D |
SUMMARY
Adjust list header padding.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Closes #12029
@junlincc
TEST PLAN
1 - Go to any major list (charts, dashboards, databases, etc)
2 - Check header padding
ADDITIONAL INFORMATION