Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styling for change dataset confirmation #12471

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jan 12, 2021

SUMMARY

Set the confirm modal to width 432px

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #12471 (d63ceb5) into master (75f927b) will increase coverage by 4.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12471      +/-   ##
==========================================
+ Coverage   62.76%   67.12%   +4.36%     
==========================================
  Files        1015     1015              
  Lines       49526    50238     +712     
  Branches     5080     5130      +50     
==========================================
+ Hits        31084    33722    +2638     
+ Misses      18233    16386    -1847     
+ Partials      209      130      -79     
Flag Coverage Δ
cypress 51.30% <0.00%> (?)
javascript 60.75% <100.00%> (+<0.01%) ⬆️
python 64.53% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/datasource/ChangeDatasourceModal.tsx 83.95% <100.00%> (-0.86%) ⬇️
superset/css_templates/api.py 94.54% <0.00%> (-1.20%) ⬇️
...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx 74.71% <0.00%> (-0.87%) ⬇️
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 76.08% <0.00%> (-0.84%) ⬇️
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 60.41% <0.00%> (-0.64%) ⬇️
superset/charts/api.py 80.86% <0.00%> (-0.60%) ⬇️
...tend/src/views/CRUD/annotation/AnnotationModal.tsx 66.14% <0.00%> (-0.53%) ⬇️
...erset-frontend/src/SqlLab/components/ResultSet.tsx 66.35% <0.00%> (-0.32%) ⬇️
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 46.78% <0.00%> (-0.24%) ⬇️
... and 195 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f927b...d63ceb5. Read the comment docs.

@adam-stasiak
Copy link
Contributor

Confirm modal should be 432 or the green area 432? You can see that exact width of modal is 408
image
image

@hughhhh hughhhh merged commit 7ac6e61 into master Jan 13, 2021
@hughhhh hughhhh deleted the hugh-fix-confirmDatasetStyle branch January 13, 2021 17:48
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
@mistercrunch mistercrunch added 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v1.0.1 🍒 1.0.1 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants