Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard_rbac): dashboard lists #12680

Merged
merged 50 commits into from
Jan 31, 2021
Merged

feat(dashboard_rbac): dashboard lists #12680

merged 50 commits into from
Jan 31, 2021

Commits on Jan 22, 2021

  1. feat: add dashboard roles to support dashboard level access

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    ca7e89f View commit details
    Browse the repository at this point in the history

  2. fix: dashboard filter logic

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    0f1a6db View commit details
    Browse the repository at this point in the history

  3. fix: negate dashboard has any roles

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    39b6b2e View commit details
    Browse the repository at this point in the history

  4. fix: pre-commit

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    9884bc3 View commit details
    Browse the repository at this point in the history

  5. fix: unused imports

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    3eb61b3 View commit details
    Browse the repository at this point in the history

  6. fix: unused imports and invalid naming

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    47235a4 View commit details
    Browse the repository at this point in the history

  7. fix: hopefully last lint issue

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    2f13075 View commit details
    Browse the repository at this point in the history

  8. fix: adapt to changes

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    9d26d30 View commit details
    Browse the repository at this point in the history

  9. fix: fix pre-commit

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    55199ed View commit details
    Browse the repository at this point in the history

  10. fix: extract id from role

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    dcc8e66 View commit details
    Browse the repository at this point in the history

  11. fix: extract hasNoRoleBasedAccess

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    c560de8 View commit details
    Browse the repository at this point in the history

  12. fix: pylint bad method name casing :)

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    0b869a2 View commit details
    Browse the repository at this point in the history

  13. fix: pre-commit non typed method

    amitmiran137 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    27f8fb9 View commit details
    Browse the repository at this point in the history

  14. fix: remove redundant pass

    @amitmiran137
    amitmiran137 authored Jan 22, 2021
    Configuration menu
    Copy the full SHA
    0223844 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2021

  1. feat: allow managing dashboard roles from the viewbased dashboard editor

    amitmiran137 committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    aa2e53e View commit details
    Browse the repository at this point in the history

  2. fix: pre-commit :)

    amitmiran137 committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    58b680b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. test: dashboard lists API and view endpoints

    amitmiran137 committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    8714b8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/dashboard_access_roles 

    * master: (52 commits)
  docs: Updates to Superset Site for 1.0 (apache#12626)
  test(native-filters): scoping tree in native filters modal (apache#12655)
  Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219)
  Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224)
  Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227)
  feat(native-filters): apply scoping of native filters to dashboard (apache#12716)
  Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223)
  Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245)
  fix: missing select menu background (apache#12759)
  fix(explore): incorrect missing datasource condition (apache#12758)
  feat: default timepicker to last week when dataset is changed (apache#12609)
  feat(explore): allow opening charts with missing dataset (apache#12705)
  chore: upgrade Cypress to 6.2.1 (apache#12605)
  refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218)
  feat: Adding option to set_database_uri CLI command (apache#12740)
  docs: Fixed typo on line 348 (apache#12739)
  Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214)
  docs: Remove gatsby-plugin-offline (apache#12693)
  test: oracle engine spec (apache#12615)
  test: hive db engine spec (apache#12520)
  ...
    amitmiran137 committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    1d3e3ae View commit details
    Browse the repository at this point in the history

  3. chore: update down revision

    amitmiran137 committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    60e92a3 View commit details
    Browse the repository at this point in the history

  4. fix: license check and pre-commit

    amitmiran137 committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    ff92508 View commit details
    Browse the repository at this point in the history

  5. fix: mypy pre-commit issues

    amitmiran137 committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    c8fadb9 View commit details
    Browse the repository at this point in the history

  6. test: add security_dataset_tests.py and removed non fixture test that… 

    … created coupling between tests
    amitmiran137 committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    061ce2f View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. fix: decouple test

    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    af5d30f View commit details
    Browse the repository at this point in the history

  2. fix: add_role if not exists

    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    b4d2cbb View commit details
    Browse the repository at this point in the history

  3. fix: decouple another test

    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    906fb50 View commit details
    Browse the repository at this point in the history

  4. fix: decouple another test

    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    16d4061 View commit details
    Browse the repository at this point in the history

  5. fix: pre-commit :)

    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    0c11ffc View commit details
    Browse the repository at this point in the history

  6. fix: make user creation with roles to copy role form gamma and and to… 

    … leave behind dataset permissions
    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    9c0b6a6 View commit details
    Browse the repository at this point in the history

  7. fix: make copy_role optional and False by default

    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    2b8cd8e View commit details
    Browse the repository at this point in the history

  8. fix: pre commit ;)

    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    83d76ce View commit details
    Browse the repository at this point in the history

  9. fix: pre commit ;)

    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    90a32fd View commit details
    Browse the repository at this point in the history

  10. fix: hopfully last decoupling

    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    e7a4770 View commit details
    Browse the repository at this point in the history

  11. fix: remove dependency from gamma user

    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    7036216 View commit details
    Browse the repository at this point in the history

  12. fix: another try

    amitmiran137 committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    14a7d74 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. fix: after cr comments

    amitmiran137 committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    2c2ade8 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Update roles description 

    Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
    @amitmiran137 @ktmud
    amitmiran137 and ktmud authored Jan 29, 2021
    Configuration menu
    Copy the full SHA
    903e3ba View commit details
    Browse the repository at this point in the history

  2. chore(after CR) : dashboard_has_roles variable and usages in queries 

    should_create_roles
    amitmiran137 committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    63051e7 View commit details
    Browse the repository at this point in the history

  3. chore(after CR) : move to dashboard util

    amitmiran137 committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    7b7da44 View commit details
    Browse the repository at this point in the history

  4. chore(after CR) : remove irrelevant slugs

    amitmiran137 committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    f6c7cbe View commit details
    Browse the repository at this point in the history

  5. chore(after CR) : remove unused method

    amitmiran137 committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    225493d View commit details
    Browse the repository at this point in the history

  6. chore(after CR) : remove const

    amitmiran137 committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    60d2d91 View commit details
    Browse the repository at this point in the history

  7. chore: changes after CR

    amitmiran137 committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    84bb61e View commit details
    Browse the repository at this point in the history

  8. feat: DASHBOARD_RBAC ff support

    amitmiran137 committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    cae1556 View commit details
    Browse the repository at this point in the history

  9. fix: pre-commit

    amitmiran137 committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    2826b77 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2021

  1. chore: is_feature_enabled("DASHBOARD_RBAC") on every usage

    amitmiran137 committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    d337209 View commit details
    Browse the repository at this point in the history

  2. fix: after CR

    amitmiran137 committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    29a5bc5 View commit details
    Browse the repository at this point in the history

  3. fix: roles_based_query inside the if is_feature_enabled("DASHBOARD_RB… 

    …AC")
    amitmiran137 committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    ac45a58 View commit details
    Browse the repository at this point in the history

  4. fix: replace assert actions with the common assert pattern

    amitmiran137 committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    594e9f2 View commit details
    Browse the repository at this point in the history

  5. feat: FF the dashboard CRUD view with the DASHBOARD_RBAC

    amitmiran137 committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    80c26ae View commit details
    Browse the repository at this point in the history

  6. Revert "feat: FF the dashboard CRUD view with the DASHBOARD_RBAC" 

    This reverts commit 80c26ae
    amitmiran137 committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    812bb87 View commit details
    Browse the repository at this point in the history