-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Replace space with tabulator and enter as separators #12730
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12730 +/- ##
==========================================
- Coverage 66.83% 66.41% -0.42%
==========================================
Files 1022 1022
Lines 49992 49992
Branches 4892 5023 +131
==========================================
- Hits 33410 33201 -209
- Misses 16457 16666 +209
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
SUMMARY
Disable confirming value with space button and replace it with tabulator and enter buttons - now we can use multi-word values like "Russian Federation".
Closes #12644
Fixes #12644
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Nagranie.z.ekranu.2021-01-25.o.09.51.49.mov
TEST PLAN
ADDITIONAL INFORMATION
CC: @junlincc @zuzana-vej @villebro