fix(explore): pie chart label bugs #13052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
force-pushed
the
villebro/bump-superset-ui-0.17.8
branch
from
e8c0680 to
a838414
Compare
villebro
force-pushed
the
villebro/bump-superset-ui-0.17.8
branch
from
a838414 to
673aa73
Compare
dpgaspar
approved these changes
Feb 10, 2021
simcha90
approved these changes
Feb 10, 2021
simcha90
reviewed
Feb 10, 2021
| .map(type => ({ | ||
| key: type, | ||
| value: registry.get(type), | ||
| })) | ||
| .concat( | ||
| registry | ||
| .entries() | ||
| .filter(entry => !entry.value.isNativeFilter) | ||
| .filter(entry => { |
There was a problem hiding this comment.
may be move it to some utils like
const getVisibleCharts = ({ behaviours } = {}) => behaviors?.includes(Behavior.CROSS_FILTER) || !behaviors?.length;
and use it like:
.filter(type =>getVisibleCharts(registry.get(type)))
and
.filter(entry =>getVisibleCharts(entry.value))
84f51b8 to
d7aae26
Compare
villebro
force-pushed
the
villebro/bump-superset-ui-0.17.8
branch
from
d7aae26 to
4fbb2a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #13052 +/- ##
==========================================
+ Coverage 53.06% 61.85% +8.79%
==========================================
Files 489 546 +57
Lines 17314 20157 +2843
Branches 4482 5272 +790
==========================================
+ Hits 9187 12469 +3282
+ Misses 8127 7475 -652
- Partials 0 213 +213
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
approved these changes
Feb 11, 2021
6 tasks
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 14, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 14, 2021
* master: (30 commits) refactor(native-filters): decouple params from filter config modal (first phase) (apache#13021) fix(native-filters): set currentValue null when empty (apache#13000) Custom superset_config.py + secret envs (apache#13096) Update http error code from 400 to 403 (apache#13061) feat(native-filters): add storybook entry for select filter (apache#13005) feat(native-filters): Time native filter (apache#12992) Force pod restart on config changes (apache#13056) feat(cross-filters): add cross filters (apache#12662) fix(explore): Enable selecting an option not included in suggestions (apache#13029) Improves RTL configuration (apache#13079) Added a note about the ! prefix for breaking changes to CONTRIBUTING.md (apache#13083) chore: lock down npm to v6 (apache#13069) fix: API tests, make them possible to run independently again (apache#13076) fix: add config to disable dataset ownership on the old api (apache#13051) add required * indicator to message content/notif method (apache#12931) fix: Retroactively add granularity param to charts (apache#12960) fix(ci): multiline regex in change detection (apache#13075) feat(style): hide dashboard header by url parameter (apache#12918) fix(explore): pie chart label bugs (apache#13052) fix: Disabled state button transition time (apache#13008) ...
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Bump
superset-uipackages to version 0.17.8 and fix a the following Pie Chart bugs:label_typein the plugin butpie_label_typein the control panel. To fix this, the generic name was chosen (will make it easier to reuse the control value later when switching between chart types) and all references topie_label_typein exising chart metadata was renamed tolabel_type.Also updates some unrelated code that depends on changes to
superset-ui/corethat relate to native filter metadata.TEST PLAN
Verify that both up and down migration works, and that pie chart works properly.
ADDITIONAL INFORMATION