Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removes Popover duplication #13462

Merged
merged 1 commit into from
Mar 30, 2021
Merged

chore: Removes Popover duplication #13462

merged 1 commit into from
Mar 30, 2021

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Mar 4, 2021 •
edited
Loading

SUMMARY

Removes Popover duplication.

TEST PLAN

1 - Execute all tests.
2 - All tests should pass.

@rusackas @junlincc

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 4, 2021 •
edited
Loading

Codecov Report

Merging #13462 (d62ed59) into master (9773aba) will increase coverage by 1.55%.
The diff coverage is 100.00%.

❗ Current head d62ed59 differs from pull request most recent head f56c213. Consider uploading reports for the commit f56c213 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13462      +/-   ##
==========================================
+ Coverage   75.91%   77.47%   +1.55%     
==========================================
  Files         933      932       -1     
  Lines       47185    47183       -2     
  Branches     5872     5858      -14     
==========================================
+ Hits        35821    36554     +733     
+ Misses      11191    10487     -704     
+ Partials      173      142      -31
Flag Coverage Δ
cypress 56.25% <ø> (+10.23%) ⬆️
javascript 63.53% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/components/URLShortLinkButton/index.jsx 100.00% <ø> (ø)
...rontend/src/explore/components/EmbedCodeButton.jsx 80.76% <ø> (ø)
...ore/components/controls/AnnotationLayerControl.jsx 82.85% <ø> (+2.85%) ⬆️
...explore/components/controls/ColorPickerControl.jsx 85.00% <ø> (ø)
...plore/components/controls/FilterBoxItemControl.jsx 73.58% <ø> (ø)
...re/components/controls/TimeSeriesColumnControl.jsx 57.40% <ø> (ø)
...rc/explore/components/controls/ViewportControl.jsx 82.60% <ø> (ø)
superset-frontend/src/components/Popover/index.tsx 100.00% <100.00%> (ø)
...dashboard/components/FiltersBadge/DetailsPanel.tsx 67.30% <100.00%> (+9.61%) ⬆️
...ilters/FilterBar/CascadeFilters/CascadePopover.tsx 83.09% <100.00%> (+19.71%) ⬆️
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9773aba...f56c213. Read the comment docs.

rusackas
rusackas reviewed Mar 4, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like import Popover from 'src/components/Popover'; just loads a wrapper which effectively aliases import { Popover } from 'src/common/components'; - should we just point directly to the latter, and remove src/components/Popover? It seems like the only reason to keep the wrapper would be if we intend to enhance or style the "stock" popover.

@michael-s-molina
Copy link
Member Author

It seems like import Popover from 'src/components/Popover'; just loads a wrapper which effectively aliases import { Popover } from 'src/common/components'; - should we just point directly to the latter, and remove src/components/Popover? It seems like the only reason to keep the wrapper would be if we intend to enhance or style the "stock" popover.

Great question @rusackas! src/common/components will be deleted when we migrate all to src/components. The import in src/components/Popover is wrong, it should be from antd. I'll fix it!

Later we'll create and index in src/components and export all with named exports. Then we could delete src/components/Popover if there's no customization.

geido
geido approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.188.68.162:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas
rusackas approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 6fe4cc0 into apache:master Mar 30, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

amitmiran137 pushed a commit that referenced this pull request Mar 31, 2021
Merge branch 'master' into feat/dashboard_extra_jwt
51b9e71 
* master: (56 commits)
  test: Adds tests and storybook to CertifiedIcon component (#13457)
  chore: Moves CheckboxIcons to Checkbox folder (#13459)
  chore: Removes Popover duplication (#13462)
  build(deps): bump elliptic from 6.5.3 to 6.5.4 in /docs (#13527)
  fix: allow spaces in DB names (#13800)
  chore: Update PR template for SIP-59 DB migrations process (#13855)
  Add CODEOWNERS (#13759)
  feat(alerts & reports): Easier to read execution logs (#13752)
  fix: Disallows negative options remaining (#13749)
  Fix broken link (#13861)
  fix(native-filters): add global async query support to native filters (#13837)
  Displays row limit warning with Alert component (#13854)
  fix(errors): Downgrade error on stop query to a warning (#13826)
  fix(alerts and reports): Unify timestamp format on execution log view (#13718)
  fix(sqllab): warning message when rows limited (#13841)
  chore: add success log whenever a connection is working (#13811)
  fix(native-filters): improve loading styles for filter component (#13794)
  chore: update change log with cherry-picks for release 1.1 (#13824)
  feat: added support to configure the default explorer viz (#13610)
  fix(#13734): Properly escape special characters in CSV output  (#13735)
  ...
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@michael-s-molina
chore: Removes Popover duplication (apache#13462)
3d2c761
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M test:component 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michael-s-molina @rusackas @geido @mistercrunch @junlincc