chore: script for changelog #13588
Merged
chore: script for changelog #13588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilykuang
force-pushed
the
lily/change-log-script
branch
4 times, most recently
from
99ec6bf
to
019aaf1
Compare
lilykuang
force-pushed
the
lily/change-log-script
branch
from
4d12d9d
to
b2b9364
Compare
lilykuang
force-pushed
the
lily/change-log-script
branch
from
b2b9364
to
531828b
Compare
lilykuang
force-pushed
the
lily/change-log-script
branch
from
531828b
to
919165c
Compare
betodealmeida
approved these changes
Mar 16, 2021
RELEASING/changelog.py
Outdated
Comment on lines
125
to
128
| for file in commit.files: | ||
| if "superset/migrations/versions/" in file.filename: | ||
| return True | ||
| return False |
There was a problem hiding this comment.
Nit suggestion:
Suggested change
| for file in commit.files: | |
| if "superset/migrations/versions/" in file.filename: | |
| return True | |
| return False | |
| return any("superset/migrations/versions/" in file.filename for file in commit.files) |
RELEASING/changelog.py
Outdated
| detail = self._pr_logs_with_details.get(pr_number) | ||
| if detail: | ||
| return detail | ||
| else: |
There was a problem hiding this comment.
Nit: no need for else here
RELEASING/changelog.py
Outdated
Comment on lines
142
to
145
| if pr_type: | ||
| pr_type = pr_type.group().strip('"') | ||
| else: | ||
| pr_type = None |
There was a problem hiding this comment.
pr_type will already by None if it's false, so:
Suggested change
| if pr_type: | |
| pr_type = pr_type.group().strip('"') | |
| else: | |
| pr_type = None | |
| if pr_type: | |
| pr_type = pr_type.group().strip('"') |
RELEASING/changelog.py
Outdated
Comment on lines
164
to
170
| for label in labels: | ||
| risk_label = re.match( | ||
| r"^(blocking|risk|hold|revert|security vulnerability)", label.name | ||
| ) | ||
| if risk_label is not None: | ||
| return True | ||
| return False |
There was a problem hiding this comment.
I wonder if we should move the regular expression r"^(blocking|risk|hold|revert|security vulnerability)" to a constant, then this could be written:
Suggested change
| for label in labels: | |
| risk_label = re.match( | |
| r"^(blocking|risk|hold|revert|security vulnerability)", label.name | |
| ) | |
| if risk_label is not None: | |
| return True | |
| return False | |
| return any(re.match(RISKY_LABEL, label.name) for label in labels) |
RELEASING/changelog.py
Outdated
| @@ -269,14 +368,20 @@ def compare(base_parameters: BaseParameters) -> None: | |||
| help="The github access token," | |||
| " if not provided will try to fetch from GITHUB_TOKEN env var", | |||
| ) | |||
| @click.option("--risk", is_flag=True, help="show all pull request with risky labels") | |||
There was a problem hiding this comment.
Suggested change
| @click.option("--risk", is_flag=True, help="show all pull request with risky labels") | |
| @click.option("--risk", is_flag=True, help="show all pull requests with risky labels") |
betodealmeida
pushed a commit
to betodealmeida/incubator-superset
that referenced
this pull request
Mar 19, 2021
* change log with section * add risk flag for showing risk pull request * update changlog.md * lint mypy * small fixes
|
@betodealmeida @lilykuang I couldn't see #13157 in changelog although it is tagged 1.1. Something wrong? |
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* change log with section * add risk flag for showing risk pull request * update changlog.md * lint mypy * small fixes
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
--riskflag for getting a list pull request with labelsblocking|risk|hold|revert|security vulnerabilitydatabase migrations,features,fixes, andothersBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION