-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create table with long name #13871
Conversation
@@ -68,3 +70,7 @@ def load_big_data() -> None: | |||
] | |||
for i in range(1000): | |||
add_data(columns=columns, num_rows=10, table_name=f"small_table_{i}") | |||
|
|||
print("Creating table with long name") | |||
name = "".join(random.choices(string.ascii_letters + string.digits, k=64)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @amitmiran137 already create a get_random_string
function in test utils:
def get_random_string(length): |
Maybe consolidate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's possible to import the get_random_string
function here, so are you suggesting moving it outside the tests/
directory and reusing it both here and in the test?
Codecov Report
@@ Coverage Diff @@
## master #13871 +/- ##
==========================================
+ Coverage 76.78% 77.50% +0.72%
==========================================
Files 935 938 +3
Lines 47292 47385 +93
Branches 5895 5943 +48
==========================================
+ Hits 36311 36726 +415
+ Misses 10824 10515 -309
+ Partials 157 144 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
Make
superset load-examples -b
create a table with a long name (64 characters, the limit), so we can test #13858.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
superset load-examples -b -t
zcZ6VHUhetxSu1N6R9DAF1nv6IqmPd4EnmqNuWaL5sXyEYTIiPTZhMJMkoGTg9VE
(random) was created.ADDITIONAL INFORMATION