Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Adds tests to the filter scope components #13887

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds tests to the filter scope components.

TEST PLAN

1 - Execute filter scope tests.
2 - All tests should pass.

@rusackas @junlincc

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #13887 (ab6bc17) into master (8b9c142) will increase coverage by 1.20%.
The diff coverage is 90.90%.

❗ Current head ab6bc17 differs from pull request most recent head 61a1181. Consider uploading reports for the commit 61a1181 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13887      +/-   ##
==========================================
+ Coverage   77.87%   79.08%   +1.20%     
==========================================
  Files         935      935              
  Lines       47375    47379       +4     
  Branches     5964     5963       -1     
==========================================
+ Hits        36895    37468     +573     
+ Misses      10323     9784     -539     
+ Partials      157      127      -30     
Flag Coverage Δ
cypress 56.04% <70.00%> (+5.27%) ⬆️
javascript 68.22% <90.90%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...shboard/components/filterscope/FilterFieldItem.jsx 100.00% <ø> (+50.00%) ⬆️
...shboard/components/filterscope/FilterFieldTree.jsx 66.66% <ø> (+22.22%) ⬆️
...hboard/components/filterscope/FilterScopeModal.tsx 75.00% <ø> (ø)
...ard/components/filterscope/FilterScopeSelector.jsx 87.67% <ø> (+85.61%) ⬆️
...shboard/components/filterscope/FilterScopeTree.jsx 70.00% <ø> (+20.00%) ⬆️
...ponents/filterscope/renderFilterFieldTreeNodes.jsx 90.00% <ø> (+90.00%) ⬆️
...ponents/filterscope/renderFilterScopeTreeNodes.jsx 86.66% <ø> (+86.66%) ⬆️
...oard/components/nativeFilters/FilterBar/Header.tsx 87.09% <0.00%> (ø)
...frontend/src/components/Checkbox/CheckboxIcons.tsx 100.00% <100.00%> (+14.28%) ⬆️
superset-frontend/src/SqlLab/actions/sqlLab.js 63.26% <0.00%> (+0.20%) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9c142...61a1181. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rusackas rusackas merged commit 4602ead into apache:master Apr 7, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants