Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(viz): bump superset-ui 0.17.30 #14045

Merged
merged 3 commits into from
Apr 9, 2021
Merged

fix(viz): bump superset-ui 0.17.30 #14045

merged 3 commits into from
Apr 9, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Apr 9, 2021 •
edited by junlincc
Loading

SUMMARY

Pull in the following enhancements/fixes from superset-ui:

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 9, 2021 •
edited
Loading

Codecov Report

Merging #14045 (84d78aa) into master (a3b41e2) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 84d78aa differs from pull request most recent head dacdc0d. Consider uploading reports for the commit dacdc0d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14045      +/-   ##
==========================================
+ Coverage   79.12%   79.25%   +0.12%     
==========================================
  Files         938      940       +2     
  Lines       47523    47577      +54     
  Branches     5940     5970      +30     
==========================================
+ Hits        37604    37707     +103     
+ Misses       9793     9744      -49     
  Partials      126      126
Flag Coverage Δ
cypress 56.06% <ø> (+<0.01%) ⬆️
javascript 68.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/filters/components/Select/SelectFilterPlugin.tsx 80.48% <ø> (-0.47%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 90.90% <0.00%> (ø)
...dashboard/components/menu/ShareMenuItems/index.tsx 25.00% <0.00%> (ø)
...end/src/dashboard/components/SliceHeader/index.tsx 41.02% <0.00%> (ø)
superset/utils/core.py 88.95% <0.00%> (+0.12%) ⬆️
superset/connectors/sqla/models.py 88.68% <0.00%> (+0.24%) ⬆️
superset/db_engine_specs/base.py 87.44% <0.00%> (+0.44%) ⬆️
...dashboard/components/SliceHeaderControls/index.jsx 78.94% <0.00%> (+1.05%) ⬆️
superset/views/database/mixins.py 82.75% <0.00%> (+1.72%) ⬆️
superset/db_engine_specs/presto.py 84.10% <0.00%> (+2.30%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b41e2...dacdc0d. Read the comment docs.

villebro
villebro commented Apr 9, 2021
View reviewed changes
superset-frontend/package.json
"react-table": "^7.2.1",
"react-table": "^7.6.3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping to be in line with the version used in the new version of table chart: apache-superset/superset-ui#1034

villebro
villebro commented Apr 9, 2021
View reviewed changes
superset-frontend/src/components/AlteredSliceTag/AlteredSliceTag.test.jsx
expect(td.find('Cell').get(0).props.columns[i].id).toBe(v);
expect(td.find('defaultRenderer').get(0).props.columns[i].id).toBe(v);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed in react-table v. 7.3.3: TanStack/table#2584

@kgabryje kgabryje self-requested a review April 9, 2021 16:02
kgabryje
kgabryje approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit bfa6140 into apache:master Apr 9, 2021
@villebro villebro deleted the villebro/bump-superset-ui-0.17.30 branch April 9, 2021 17:49
@villebro villebro mentioned this pull request Apr 10, 2021
Merged
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@villebro
fix(viz): bump superset-ui 0.17.30 (apache#14045)
e1b8d46 
* fix(viz): bump superset-ui 0.17.30

* fix test

* bump react-table to match the version in superset-ui
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@villebro
fix(viz): bump superset-ui 0.17.30 (apache#14045)
efbbc0e 
* fix(viz): bump superset-ui 0.17.30

* fix test

* bump react-table to match the version in superset-ui
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io release:note size/M 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@villebro @kgabryje @mistercrunch @junlincc