Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom TimeRange can not input value #14084

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Apr 12, 2021

SUMMARY

closes: #14004

This PR contains:

  • fix custom date range can not input DateTime value

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

fix_custom_datepicker_before.mp4

After

fix_custom_after.mp4

TEST PLAN

Tested in local

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie requested review from rusackas and a team April 12, 2021 15:09
@junlincc junlincc added the explore:time Related to the time filters in Explore label Apr 12, 2021
@junlincc
Copy link
Member

/testenv up

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #14084 (763fbfb) into master (0dfb32c) will decrease coverage by 0.05%.
The diff coverage is 94.02%.

❗ Current head 763fbfb differs from pull request most recent head e2c9919. Consider uploading reports for the commit e2c9919 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14084      +/-   ##
==========================================
- Coverage   76.99%   76.93%   -0.06%     
==========================================
  Files         953      954       +1     
  Lines       48061    48075      +14     
  Branches     5971     5974       +3     
==========================================
- Hits        37004    36987      -17     
- Misses      10855    10891      +36     
+ Partials      202      197       -5     
Flag Coverage Δ
javascript 72.10% <87.09%> (+<0.01%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/FormRow/index.jsx 100.00% <ø> (ø)
...src/dashboard/components/PropertiesModal/index.jsx 85.61% <ø> (ø)
.../src/explore/components/controls/BoundsControl.jsx 93.93% <ø> (ø)
...trols/DateFilterControl/components/CustomFrame.tsx 92.15% <ø> (ø)
...trol/AdhocFilterEditPopoverSqlTabContent/index.jsx 63.33% <ø> (ø)
...src/explore/components/controls/SpatialControl.jsx 6.75% <ø> (ø)
...ponents/controls/TimeSeriesColumnControl/index.jsx 100.00% <ø> (ø)
...perset-frontend/src/views/CRUD/alert/AlertList.tsx 75.75% <ø> (ø)
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 73.88% <ø> (ø)
...end/src/views/CRUD/data/database/DatabaseModal.tsx 62.87% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfb32c...e2c9919. Read the comment docs.

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://34.222.40.170:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@zhaoyongjie zhaoyongjie force-pushed the fix_custom_timepicker branch from dc5140b to e2c9919 Compare April 23, 2021 06:58
@zhaoyongjie zhaoyongjie merged commit d1afca4 into apache:master Apr 23, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:time Related to the time filters in Explore size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time Picker - manually entered custom range timestamps don't "stick"
5 participants