feat: postgres connection form #14456
Conversation
| @@ -241,6 +253,8 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ | |||
| } | |||
| if (show) { | |||
| setTabKey(DEFAULT_TAB_KEY); | |||
| getAvailableDbs(); | |||
| setSelectedDb('postgresql'); | |||
There was a problem hiding this comment.
this is hardcoded for now, and doesn't do anything unless useSqlAlchemyForm is true. Eventually the db will be chosen by the user on a different step.
Codecov Report
@@ Coverage Diff @@
## master #14456 +/- ##
==========================================
- Coverage 77.40% 77.37% -0.04%
==========================================
Files 958 959 +1
Lines 48329 48388 +59
Branches 5679 5689 +10
==========================================
+ Hits 37410 37438 +28
- Misses 10719 10750 +31
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This pr is dependent on #14470 |
eschutho
force-pushed
the
elizabeth/postgres-connection-form
branch
from
cf2107d
to
7adc550
Compare
|
Rerunning tests. |
eschutho
force-pushed
the
elizabeth/postgres-connection-form
branch
from
7adc550
to
6e508bd
Compare
| id={field} | ||
| bsSize="sm" | ||
| autoComplete="off" | ||
| onChange={() => {}} |
There was a problem hiding this comment.
the functionality is set up in the next PR that has the save db: #14583
|
A significant enough portion of this PR has changed now that would warrant me closing it and leaving just the save PR for review. |
SUMMARY
This PR adds the functionality of calling databases/available api to get a list of databases that have drivers loaded and available to use. The form is built dynamically based on that information. This is currently behind a local flag, and there are no visual changes, but the piece in development is as shown below. More work is needed to hook the form up to the api on connect/save, but I'm merging often to reduce any rebasing issues and also keep PRs small.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
This is behind a local flag
useSqlAlchemyFormwhich is set to 'false'TEST PLAN
visual changes only right now, so all existing tests should pass
ADDITIONAL INFORMATION