New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix submenu header double line #14631

Merged

rusackas merged 6 commits into apache:master from preset-io:fix-submenu-views

May 14, 2021

Member

pkdotson commented May 14, 2021 •

edited

Loading

SUMMARY

This fixes issue where title of submenu is too long for column and would make text break to next line.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

after

Screen.Recording.2021-05-13.at.6.27.53.PM.mov

TEST PLAN

Go to alert & reports and annotationslist to view the fixed menus.

ADDITIONAL INFORMATION

[ x] Has associated issue: [cosmetic] Submenu on Annotation page is off #14617, [cosmetic][Alerts & Reports] Submenu of Alert and Report execution log is off #14616
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

pkdotson added 2 commits

May 13, 2021 18:01


          fix submenu header

d596065


          remove unused css

847c723

superset-github-bot bot added the preset-io label

pull-request-size bot added the size/S label

pkdotson requested review from junlincc and suddjian

May 14, 2021 01:30

This was referenced May 14, 2021

[cosmetic][Alerts & Reports] Submenu of Alert and Report execution log is off #14616

Closed

[cosmetic] Submenu on Annotation page is off #14617

Closed


          lint

f59bbcc

pull-request-size bot added size/L and removed size/S labels

codecov bot commented May 14, 2021 •

edited

Loading

Codecov Report

Merging #14631 (925e951) into master (74473e2) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #14631      +/-   ##
==========================================
+ Coverage   77.20%   77.47%   +0.27%     
==========================================
  Files         958      958              
  Lines       48492    48489       -3     
  Branches     5691     5690       -1     
==========================================
+ Hits        37437    37567     +130     
+ Misses      10855    10722     -133     
  Partials      200      200

Flag	Coverage Δ
javascript	`72.52% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ews/CRUD/annotationlayers/AnnotationLayersList.tsx	`77.35% <ø> (ø)`
...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx	`78.26% <ø> (ø)`
superset-frontend/src/components/Menu/SubMenu.tsx	`96.87% <100.00%> (+1.28%)`	⬆️
superset/models/core.py	`89.13% <0.00%> (-0.28%)`	⬇️
superset/views/core.py	`75.51% <0.00%> (+0.03%)`	⬆️
superset/utils/core.py	`89.00% <0.00%> (+0.12%)`	⬆️
superset/db_engine_specs/base.py	`88.42% <0.00%> (+0.80%)`	⬆️
superset/result_set.py	`98.38% <0.00%> (+1.61%)`	⬆️
superset/views/database/mixins.py	`82.75% <0.00%> (+1.72%)`	⬆️
superset/connectors/sqla/models.py	`90.26% <0.00%> (+2.10%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c55418d...925e951. Read the comment docs.

Member

rusackas commented May 14, 2021

Fixes #14616, Fixes #14617

Member

rusackas commented May 14, 2021

/testenv up

Contributor

github-actions bot commented May 14, 2021

@rusackas Ephemeral environment spinning up at http://34.209.38.58:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas reviewed

View reviewed changes

superset-frontend/src/components/Menu/SubMenu.tsx Outdated Show resolved Hide resolved

Member

rusackas commented May 14, 2021

@pkdotson A similar (related?) issue was pointed out to me and I opened this quick PR. Hopefully I'm not going to cause a collision there...
#14637

rusackas reviewed

View reviewed changes

superset-frontend/src/components/Menu/SubMenu.tsx Outdated Show resolved Hide resolved

Member

junlincc commented May 14, 2021

/testenv up

Member

michael-s-molina commented May 14, 2021 •

edited

Loading

Fixes #14616, Fixes #14617

@rusackas GitHub will not automatically close these issues because it doesn't check for comments. @pkdotson should add this text to the PR description.

michael-s-molina reviewed

View reviewed changes

superset-frontend/src/components/Menu/SubMenu.tsx Outdated Show resolved Hide resolved

superset-frontend/src/components/Menu/SubMenu.tsx Outdated Show resolved Hide resolved

superset-frontend/src/components/Menu/SubMenu.tsx

		@@ -42,6 +42,8 @@ const StyledHeader = styled.div`
		padding: 14px 0;
		margin-right: ${({ theme }) => theme.gridUnit * 3}px;

Member

michael-s-molina May 14, 2021

You can replace all instances of ${({ theme }) => by moving this piece of code to the top like this https://github.com/apache/superset/pull/14448/files#diff-0856ab0ce511fac9256389d5ed3635f15d77ec907de602ce32d28f072de76753

Member

rusackas May 14, 2021

Nice tip!! We should sweep through and do this all over the place, on some rainy day (probably not now).

superset-frontend/src/components/Menu/SubMenu.tsx Outdated Show resolved Hide resolved

superset-frontend/src/components/Menu/SubMenu.tsx Show resolved Hide resolved


          Merge branch 'master' of https://github.com/preset-io/superset into f…

86685d1

…ix-submenu-views

pull-request-size bot added size/M and removed size/L labels


          address comment

bd06814

pull-request-size bot added size/L and removed size/M labels


          address more comments

925e951

pkdotson mentioned this pull request

[cosmetic] submenu spacing #14643

Closed

Contributor

github-actions bot commented May 14, 2021

@junlincc Ephemeral environment spinning up at http://34.217.89.200:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Contributor

github-actions bot commented May 14, 2021

@pkdotson Ephemeral environment spinning up at http://18.236.78.240:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas approved these changes

View reviewed changes

Member

rusackas left a comment

LGTM!

Member

junlincc commented May 14, 2021

LGTM!! Thanks for the fix 😊

rusackas merged commit 60f903f into apache:master

Contributor

github-actions bot commented May 14, 2021

Ephemeral environment shutdown and build artifacts deleted.

rusackas deleted the fix-submenu-views branch

May 14, 2021 21:58

junlincc added the rush! label

henryyeh pushed a commit to preset-io/superset that referenced this pull request


          fix: fix submenu header double line (apache#14631)

5f2bb51

* fix submenu header

* remove unused css

* lint

* address comment

* address more comments

(cherry picked from commit 60f903f)

junlincc removed the rush! label

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request


          fix: fix submenu header double line (apache#14631)

1e256a9

* fix submenu header

* remove unused css

* lint

* address comment

* address more comments

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request


          fix: fix submenu header double line (apache#14631)

53f09a7

* fix submenu header

* remove unused css

* lint

* address comment

* address more comments

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request


          fix: fix submenu header double line (apache#14631)

* fix submenu header

* remove unused css

* lint

* address comment

* address more comments

mistercrunch added 🏷️ bot 🚢 1.3.0 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot preset-io size/L 🚢 1.3.0