-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check limiting factor on query results #14719
fix: check limiting factor on query results #14719
Conversation
/testenv up |
31b7f83
to
50c975e
Compare
@hughhhh Container image not yet published for this PR. Please try again when build is complete. |
@hughhhh Ephemeral environment creation failed. Please check the Actions logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #14719 +/- ##
=======================================
Coverage 77.46% 77.46%
=======================================
Files 959 959
Lines 48696 48697 +1
Branches 5739 5740 +1
=======================================
+ Hits 37724 37725 +1
Misses 10771 10771
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@hughhhh Ephemeral environment spinning up at http://54.212.99.127:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
There were errors on sql lab rendering because a translation key had a null replacement
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before in ticket
after:
Screen.Recording.2021-05-19.at.12.09.33.PM.mov
TEST PLAN
ADDITIONAL INFORMATION
closes #14711