fix name for postgresql #1482
Merged
fix name for postgresql #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the fix! |
This was referenced Feb 2, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code change in ef2670c caused tables on a postgres backend to lose the time grain selector in the table explorer (i.e. cannot see/select a time grain after this code change).
The previous code used startswith to match the database driver type (which was looking to match 'postgres' and 'postgresql').
https://github.com/airbnb/caravel/blob/8626c80d3a491b842f8262c5807154903c107747/caravel/models.py#L775
The new version requires matching the whole string so a postgresql:// uri will not match postgres.
https://github.com/airbnb/caravel/blob/ef2670ca32e8ba0a04f9dc7899db55812e2f9b46/caravel/models.py#L1365
The fix sets postgresql as the engine name. This corresponds to the sqlalchemy doc as well.