Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make Step 1 alerts configurable #15404

Merged
merged 1 commit into from
Jun 28, 2021
Merged

feat: make Step 1 alerts configurable #15404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 31 additions & 13 deletions superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,20 +555,38 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
closable={false}
css={(theme: SupersetTheme) => antDAlertStyles(theme)}
type="info"
message={t('Want to add a new database?')}
message={
connectionAlert?.ADD_DATABASE?.message ||
t('Want to add a new database?')
}
description={
<>
Any databases that allow connetions via SQL Alchemy URIs can be
added. Learn about how to connect a database driver{' '}
<a
href={DOCUMENTATION_LINK}
target="_blank"
rel="noopener noreferrer"
>
here
</a>
.
</>
connectionAlert?.ADD_DATABASE ? (
<>
Any databases that allow connetions via SQL Alchemy URIs can be
added.{' '}
<a
href={connectionAlert?.ADD_DATABASE.contact_link}
target="_blank"
rel="noopener noreferrer"
>
{connectionAlert?.ADD_DATABASE.contact_description_link}
</a>{' '}
{connectionAlert?.ADD_DATABASE.description}
</>
) : (
<>
Any databases that allow connetions via SQL Alchemy URIs can be
added. Learn about how to connect a database driver{' '}
<a
href={DOCUMENTATION_LINK}
target="_blank"
rel="noopener noreferrer"
>
here
</a>
.
</>
)
}
/>
</div>
Expand Down