Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RTL for Database Connections #15513

Merged
merged 29 commits into from
Jul 1, 2021

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Jul 1, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

AAfghahi and others added 28 commits June 11, 2021 12:28
* added alerts

* revisions

* added icon
@AAfghahi AAfghahi changed the base branch from master to pexdax/db-connection-ui July 1, 2021 19:33
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #15513 (700198e) into pexdax/db-connection-ui (1a16c49) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           pexdax/db-connection-ui   #15513      +/-   ##
===========================================================
- Coverage                    77.25%   77.07%   -0.18%     
===========================================================
  Files                          975      976       +1     
  Lines                        50882    51204     +322     
  Branches                      6740     6885     +145     
===========================================================
+ Hits                         39307    39464     +157     
- Misses                       11359    11521     +162     
- Partials                       216      219       +3     
Flag Coverage Δ
javascript 71.55% <100.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx 92.85% <ø> (-1.27%) ⬇️
...rset-frontend/src/components/InfoTooltip/index.tsx 100.00% <100.00%> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx 49.37% <0.00%> (-25.96%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/styles.ts 86.11% <0.00%> (-11.15%) ⬇️
...RUD/data/database/DatabaseModal/SqlAlchemyForm.tsx 92.30% <0.00%> (-7.70%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 48.23% <0.00%> (-4.58%) ⬇️
superset-frontend/src/components/Icon/index.tsx 100.00% <0.00%> (ø)
...erset-frontend/src/components/IconButton/index.tsx 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a16c49...700198e. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 1, 2021
@hughhhh hughhhh merged commit 4fc5589 into apache:pexdax/db-connection-ui Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants