chore: add changed_on_delta_humanized field on dashboard schema #15542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
commented
Jul 5, 2021
| @@ -159,6 +159,7 @@ class DashboardGetResponseSchema(Schema): | |||
| owners = fields.List(fields.Nested(UserSchema)) | |||
| roles = fields.List(fields.Nested(RolesSchema)) | |||
| table_names = fields.String() # legacy nonsense | |||
| changed_on_humanized = fields.String(data_key="changed_on_delta_humanized") | |||
There was a problem hiding this comment.
superset.models.helps.AuditMixinNullable.changed_on_delta_humanizedis a instance method, unable to serializes.- ensure DashboardRestApi list_column and dashboard metadata are the same
There was a problem hiding this comment.
to ensure 2. we should add show_columns = list_columns on the REST API class, and follow the same existing pattern
There was a problem hiding this comment.
I will follow this PR, thanks, Daniel.
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #15542 +/- ##
===========================================
+ Coverage 58.93% 76.96% +18.03%
===========================================
Files 373 976 +603
Lines 12014 51298 +39284
Branches 2945 6912 +3967
===========================================
+ Hits 7080 39480 +32400
- Misses 4755 11599 +6844
- Partials 179 219 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
LGTM! |
suddjian
approved these changes
Jul 7, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…he#15542) * chore: add changed_on_delta_humanized field on dashboard schema * fix ut
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…he#15542) * chore: add changed_on_delta_humanized field on dashboard schema * fix ut
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…he#15542) * chore: add changed_on_delta_humanized field on dashboard schema * fix ut
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
added
changed_on_delta_humanizedfield on dashboard schema. ensure rest API has this response data.related PR: #15186
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION