Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: available endpoint showing specs without drivers #15587

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

We were showing specs without drivers in the /database/available/ endpoint. Simple fix.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh self-requested a review July 8, 2021 15:24
@hughhhh
Copy link
Member

hughhhh commented Jul 8, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

@hughhhh Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

@hughhhh Ephemeral environment creation failed. Please check the Actions logs for details.

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #15587 (5009466) into master (ae160f7) will decrease coverage by 0.15%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15587      +/-   ##
==========================================
- Coverage   76.87%   76.72%   -0.16%     
==========================================
  Files         976      976              
  Lines       51293    51295       +2     
  Branches     6907     6907              
==========================================
- Hits        39431    39355      -76     
- Misses      11643    11721      +78     
  Partials      219      219              
Flag Coverage Δ
hive ?
mysql 81.54% <50.00%> (-0.01%) ⬇️
postgres 81.56% <50.00%> (-0.01%) ⬇️
python 81.65% <50.00%> (-0.30%) ⬇️
sqlite 81.17% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/api.py 92.93% <50.00%> (-0.31%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.44% <0.00%> (-17.07%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-1.06%) ⬇️
superset/db_engine_specs/base.py 88.14% <0.00%> (-0.40%) ⬇️
superset/connectors/sqla/models.py 88.26% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 88.97% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae160f7...5009466. Read the comment docs.

@betodealmeida
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

@betodealmeida Ephemeral environment spinning up at http://54.202.216.174:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@hughhhh hughhhh merged commit 301b94f into apache:master Jul 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

Ephemeral environment shutdown and build artifacts deleted.

@rosemarie-chiu
Copy link
Contributor

🏷 2021.27

henryyeh pushed a commit to preset-io/superset that referenced this pull request Jul 8, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.27 size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants