Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix(dashboard): Open "View Chart in Explore" in the same window" #15588

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jul 8, 2021

Reverts #14778

We'll open a new PR to make this a real link you can command/right-click on.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #15588 (36f1e6d) into master (301b94f) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 36f1e6d differs from pull request most recent head a5d7443. Consider uploading reports for the commit a5d7443 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15588   +/-   ##
=======================================
  Coverage   76.73%   76.73%           
=======================================
  Files         976      976           
  Lines       51318    51318           
  Branches     6907     6907           
=======================================
  Hits        39378    39378           
  Misses      11721    11721           
  Partials      219      219           
Flag Coverage Δ
javascript 71.42% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/explore/exploreUtils/index.js 66.45% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301b94f...a5d7443. Read the comment docs.

@rusackas rusackas changed the title Revert "fix(dashboard): Open "View Chart in Explore" in the same window" fix: Revert "fix(dashboard): Open "View Chart in Explore" in the same window" Jul 8, 2021
@graceguo-supercat graceguo-supercat merged commit 026eefd into master Jul 8, 2021
@rusackas rusackas deleted the revert-14778-fix/issue_14672 branch July 8, 2021 23:00
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants