Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert Celery 5 upgrade #16039

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

robdiciuccio
Copy link
Member

@robdiciuccio robdiciuccio commented Aug 3, 2021

SUMMARY

Reverts Celery 5.x upgrade in #15927 due to breaking changes per SIP-57.

Per the Celery 5.0 upgrade docs:

Celery 5.0 introduces a new CLI implementation which isn’t completely backwards compatible.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #16039 (28e2609) into master (4cb79e5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16039   +/-   ##
=======================================
  Coverage   76.90%   76.90%           
=======================================
  Files         995      995           
  Lines       52842    52842           
  Branches     6709     6709           
=======================================
  Hits        40640    40640           
  Misses      11976    11976           
  Partials      226      226           
Flag Coverage Δ
hive 81.32% <ø> (ø)
mysql 81.62% <ø> (ø)
postgres 81.64% <ø> (ø)
presto 81.48% <ø> (ø)
python 82.16% <ø> (ø)
sqlite 81.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb79e5...28e2609. Read the comment docs.

@robdiciuccio robdiciuccio merged commit 0462252 into apache:master Aug 3, 2021
@robdiciuccio robdiciuccio deleted the rd/revert-celery5 branch August 3, 2021 16:27
@AkhilVinayakMS AkhilVinayakMS mentioned this pull request Aug 17, 2021
8 tasks
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants