Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trino support server-cert #16346

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Conversation

dungdm93
Copy link
Contributor

Signed-off-by: Đặng Minh Dũng dungdm93@live.com

SUMMARY

Add support Server certificate for Trino database

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot from 2021-08-19 07-59-06

TESTING INSTRUCTIONS

Write & pass unit-tests

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #16346 (6f0b014) into master (cf3f0e5) will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16346   +/-   ##
=======================================
  Coverage   76.81%   76.82%           
=======================================
  Files        1049     1049           
  Lines       56654    56682   +28     
  Branches     7851     7851           
=======================================
+ Hits        43517    43544   +27     
- Misses      12884    12885    +1     
  Partials      253      253           
Flag Coverage Δ
mysql 82.02% <71.42%> (+0.01%) ⬆️
postgres 82.03% <71.42%> (+0.01%) ⬆️
python 82.11% <71.42%> (+0.01%) ⬆️
sqlite 81.71% <71.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/async_query_manager.py 82.24% <0.00%> (ø)
superset/db_engine_specs/trino.py 63.85% <83.33%> (+4.13%) ⬆️
superset/db_engine_specs/base.py 88.15% <0.00%> (-0.05%) ⬇️
superset/db_engine_specs/hana.py 95.00% <0.00%> (ø)
superset/db_engine_specs/hive.py 70.27% <0.00%> (ø)
superset/connectors/sqla/utils.py 92.15% <0.00%> (ø)
superset/db_engine_specs/crate.py 92.30% <0.00%> (ø)
superset/db_engine_specs/drill.py 86.84% <0.00%> (ø)
superset/db_engine_specs/druid.py 86.27% <0.00%> (ø)
superset/db_engine_specs/kylin.py 94.11% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3f0e5...6f0b014. Read the comment docs.

@dungdm93
Copy link
Contributor Author

Hello @mistercrunch, could you please review this one

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really big thanks for this added feature! Waiting for tests to pass, if all is good I think this is good to go.

@villebro
Copy link
Member

@dungdm93 apparently there's a flaky linting rule that's failing CI - let me try to fix that

@villebro
Copy link
Member

@dungdm93 your PR got blocked by redis typeshed stubs being updated today which was fixed here: #17555. If you rebase and remove those changes to superset/utils/async_query_manager.py this should be good to go.

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
@dungdm93
Copy link
Contributor Author

Many thank @villebro for your support.
rebased from master and revert changes in superset/utils/async_query_manager.py

@villebro villebro merged commit ebb3419 into apache:master Nov 26, 2021
@dungdm93 dungdm93 deleted the trino-server-cert branch November 26, 2021 11:58
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants