feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 #16493

stephenLYZ · 2021-08-29T12:09:28Z

🏆 Enhancements

This PR implements Extra Control on the area chart V2, and the chart's update mechanism is using setControlValue hook. There are some differences or improvements:

In explore the stack control will be updated if Extra Control is updated. But for NVD3, updating extra control does not update the stack control.
Here only keep Stack and Expend two options (Stream Graph will come soon) and add a new None option, which can cancel the stack style.
Another UI difference is the extra control button which uses the same radio control as the control panel instead of NVD3 radio button.

explore

before

2022-05-08.8.31.21.mov

after

2022-05-08.8.06.14.mov

dashboard

before

2022-05-08.8.31.59.mov

after

2022-05-08.8.35.59.mov

TESTING INSTRUCTIONS

add Exta Control to the time-series area chart
save and go to dashboard
test the control and see results

ADDITIONAL INFORMATION

Has associated issue: [echarts]Support Extra Controls on the Time-Series Area Chart for feature parity #16298
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2021-08-29T12:27:57Z

Codecov Report

Merging #16493 (0a86dbb) into master (0e38c68) will decrease coverage by 0.01%.
The diff coverage is 54.92%.

@@            Coverage Diff             @@
##           master   #16493      +/-   ##
==========================================
- Coverage   66.54%   66.52%   -0.02%     
==========================================
  Files        1726     1727       +1     
  Lines       64875    64918      +43     
  Branches     6830     6843      +13     
==========================================
+ Hits        43169    43188      +19     
- Misses      19975    19997      +22     
- Partials     1731     1733       +2

Flag	Coverage Δ
javascript	`51.35% <54.92%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../shared-controls/components/RadioButtonControl.tsx	`0.00% <ø> (ø)`
...hart-echarts/src/MixedTimeseries/transformProps.ts	`0.00% <ø> (ø)`
.../plugin-chart-echarts/src/MixedTimeseries/types.ts	`100.00% <ø> (ø)`
...chart-echarts/src/Timeseries/Area/controlPanel.tsx	`40.00% <ø> (ø)`
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx	`0.00% <ø> (ø)`
...ugins/plugin-chart-echarts/src/Timeseries/types.ts	`100.00% <ø> (ø)`
...gin-chart-echarts/src/components/ExtraControls.tsx	`0.00% <0.00%> (ø)`
...frontend/plugins/plugin-chart-echarts/src/types.ts	`100.00% <ø> (ø)`
...et-frontend/src/components/Chart/ChartRenderer.jsx	`54.23% <ø> (ø)`
.../src/dashboard/components/gridComponents/Chart.jsx	`60.60% <ø> (ø)`
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e38c68...0a86dbb. Read the comment docs.

stale · 2022-04-16T14:56:09Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

jhult · 2022-04-20T12:37:27Z

Any news on getting this merged?

stephenLYZ · 2022-04-21T07:56:03Z

@jhult I will finish this PR next week.

stephenLYZ · 2022-05-13T17:14:48Z

/testenv up FEATURE_GENERIC_CHART_AXES=true

github-actions · 2022-05-13T17:40:54Z

@stephenLYZ Ephemeral environment spinning up at http://34.208.141.177:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

jinghua-qa · 2022-06-03T06:40:02Z

LGTM！

zhaoyongjie

Thanks for the awesome new feature! left some unblocked comments. If have time to add more unit-test in the separate PR.

zhaoyongjie · 2022-06-07T10:02:04Z

superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts

@@ -191,7 +191,7 @@ export default function transformProps(
      areaOpacity: opacity,
      seriesType,
      showValue,
-      stack,
+      stack: Boolean(stack),


no blocking nit

Suggested change

stack: Boolean(stack),

!!stack

zhaoyongjie · 2022-06-08T08:01:32Z

superset-frontend/plugins/plugin-chart-echarts/src/components/ExtraControls.tsx

+  setControlValue?: HandlerFunction;
+}) {
+  const { stack, area } = formData;
+  const [extraValue, setExtraValue] = useState<JsonValue | undefined>(


Suggested change

const [extraValue, setExtraValue] = useState<JsonValue | undefined>(

if (area === undefined) {

return []

}

const [extraValue, setExtraValue] = useState<JsonValue | undefined>(

github-actions · 2022-06-08T17:00:28Z

Ephemeral environment shutdown and build artifacts deleted.

feat(echarts): [feature-parity] support extra control

6c58fb9

pull-request-size bot added the size/M label Aug 29, 2021

stephenLYZ mentioned this pull request Aug 29, 2021

feat(plugin-chart-echarts): [feature-parity] support Extra Control on the time-series area chart apache-superset/superset-ui#1336

Closed

stephenLYZ changed the title ~~feat(echarts): [dashboard] support extra control for the time-series area chart~~ feat(dashboard): [[feature-parity]] support extra control for the time-series area chart Aug 30, 2021

stephenLYZ changed the title ~~feat(dashboard): [[feature-parity]] support extra control for the time-series area chart~~ feat(dashboard): [feature-parity] support extra control for the time-series area chart Aug 30, 2021

stephenLYZ closed this Aug 30, 2021

stephenLYZ reopened this Aug 30, 2021

junlincc added the viz:charts:echarts Related to Echarts label Aug 31, 2021

stephenLYZ added 2 commits December 1, 2021 21:38

Merge branch 'master' into feat-area-extra-control

86e8f03

add extra control for plugin

ae8a35a

pull-request-size bot added size/L and removed size/M labels Dec 1, 2021

stephenLYZ changed the title ~~feat(dashboard): [feature-parity] support extra control for the time-series area chart~~ feat(plugin-chart-echarts): [feature-parity] support extra control for the time-series area chart Dec 1, 2021

stale bot added the inactive Inactive for >= 30 days label Apr 16, 2022

stale bot removed the inactive Inactive for >= 30 days label Apr 20, 2022

stephenLYZ added 4 commits May 6, 2022 18:36

Merge branch 'master' into feat-area-extra-control

22cdffe

refactor: extract ExtraControl

c0a7e7d

fix: lint

04f9dc4

fix some problems

c665ce4

stephenLYZ changed the title ~~feat(plugin-chart-echarts): [feature-parity] support extra control for the time-series area chart~~ feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 May 8, 2022

stephenLYZ requested review from villebro, zhaoyongjie and rusackas May 9, 2022 14:40

Merge branch 'master' into feat-area-extra-control

90efeb7

stephenLYZ added 2 commits May 16, 2022 23:50

Merge branch 'master' into feat-area-extra-control

48a8a08

Merge branch 'master' into feat-area-extra-control

b85ed32

Merge branch 'master' into feat-area-extra-control

0a86dbb

zhaoyongjie approved these changes Jun 8, 2022

View reviewed changes

stephenLYZ merged commit eab0009 into apache:master Jun 8, 2022

stephenLYZ mentioned this pull request Jun 29, 2022

[TimeSeries Area chart] REGRESSION : New area chart don't have the "stack / expand" option #20537

Closed

snyk-bot mentioned this pull request Jun 10, 2023

[Snyk] Security upgrade webpack from 5.67.0 to 5.76.0 ShareChat/superset#7

Open

laxmanraparthi mentioned this pull request Jun 28, 2023

[Snyk] Fix for 13 vulnerabilities ShareChat/superset#15

Open

laxmanraparthi mentioned this pull request Nov 27, 2023

[Snyk] Security upgrade webpack from 5.67.0 to 5.76.0 ShareChat/superset#62

Open

laxmanraparthi mentioned this pull request Jan 6, 2024

[Snyk] Security upgrade webpack from 5.52.1 to 5.76.0 ShareChat/superset#114

Open

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Feb 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 #16493

feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 #16493

stephenLYZ commented Aug 29, 2021 •

edited

Loading

codecov bot commented Aug 29, 2021 •

edited

Loading

stale bot commented Apr 16, 2022

jhult commented Apr 20, 2022

stephenLYZ commented Apr 21, 2022

stephenLYZ commented May 13, 2022

github-actions bot commented May 13, 2022

jinghua-qa commented Jun 3, 2022

zhaoyongjie left a comment

zhaoyongjie Jun 7, 2022

zhaoyongjie Jun 8, 2022

github-actions bot commented Jun 8, 2022

feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 #16493

feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 #16493

Conversation

stephenLYZ commented Aug 29, 2021 • edited Loading

explore

before

after

dashboard

before

after

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Aug 29, 2021 • edited Loading

Codecov Report

stale bot commented Apr 16, 2022

jhult commented Apr 20, 2022

stephenLYZ commented Apr 21, 2022

stephenLYZ commented May 13, 2022

github-actions bot commented May 13, 2022

jinghua-qa commented Jun 3, 2022

zhaoyongjie left a comment

Choose a reason for hiding this comment

zhaoyongjie Jun 7, 2022

Choose a reason for hiding this comment

zhaoyongjie Jun 8, 2022

Choose a reason for hiding this comment

github-actions bot commented Jun 8, 2022

stephenLYZ commented Aug 29, 2021 •

edited

Loading

codecov bot commented Aug 29, 2021 •

edited

Loading