Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Dashboard): Implement dedicated message for missing dataset #16959

Merged
merged 4 commits into from
Oct 8, 2021
Merged

chore(Dashboard): Implement dedicated message for missing dataset #16959

merged 4 commits into from
Oct 8, 2021

Conversation

geido
Copy link
Member

@geido geido commented Oct 4, 2021

SUMMARY

Implements a dedicated "Missing dataset" message to replace the generic "Unexpected error".

BEFORE

Screen Shot 2021-10-01 at 10 48 24 AM

AFTER

Screen Shot 2021-10-04 at 19 12 21

TESTING INSTRUCTIONS

  1. Open a Dashboard with a dataset that does not exist
  2. Observe the error message

ADDITIONAL INFORMATION

@stephenLYZ
Copy link
Member

LGTM! Thanks for the improvement!

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #16959 (dd73f64) into master (a782a62) will decrease coverage by 0.00%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16959      +/-   ##
==========================================
- Coverage   76.70%   76.70%   -0.01%     
==========================================
  Files        1030     1031       +1     
  Lines       55056    55091      +35     
  Branches     7465     7475      +10     
==========================================
+ Hits        42231    42257      +26     
- Misses      12576    12585       +9     
  Partials      249      249              
Flag Coverage Δ
javascript 70.91% <72.72%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/setup/setupErrorMessages.ts 0.00% <0.00%> (ø)
...nents/ErrorMessage/DatasetNotFoundErrorMessage.tsx 88.88% <88.88%> (ø)
superset-frontend/src/components/Select/Select.tsx 92.25% <0.00%> (-0.30%) ⬇️
...e/components/controls/SelectAsyncControl/index.jsx
...e/components/controls/SelectAsyncControl/index.tsx 81.08% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a782a62...dd73f64. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 42efcdf into apache:master Oct 8, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard][error msg] Can we have specific error info in the error title
6 participants