Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB Connections): removing paramProperties #17024

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Oct 7, 2021

SUMMARY

We are refactoring portions of the Database Connection Form UI. We originally had a paramProperties field in state that would check for x-encrypted-true for database creation. However, we later replaced this with a parameters_schema calculated column. This PR is removing paramProperties.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh
Copy link
Member

hughhhh commented Oct 7, 2021

Don't we have to remove how it is being populated as well ?

@AAfghahi
Copy link
Member Author

AAfghahi commented Oct 7, 2021

@hughhhh hughhhh merged commit 50ad09b into apache:master Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #17024 (30446ef) into master (9ef2861) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17024      +/-   ##
==========================================
- Coverage   76.93%   76.93%   -0.01%     
==========================================
  Files        1030     1030              
  Lines       55086    55085       -1     
  Branches     7478     7477       -1     
==========================================
- Hits        42381    42380       -1     
  Misses      12454    12454              
  Partials      251      251              
Flag Coverage Δ
javascript 70.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 43.79% <ø> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef2861...30446ef. Read the comment docs.

@AAfghahi AAfghahi deleted the ch27108_paramProperties branch October 7, 2021 19:28
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants