fix: Workaround for Pandas Timestamp.isoformat issue #17426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Pandas timestamp differs from the
datetime.datetime
object and the isoformat function doesn't include thetimespec
argument (the help description is wrong), i.e., it results in errors of the form,See pandas-dev/pandas#26131 for more details. The fix is to convert the pandas.TImestamp
object into a
datetime.datetime` object which is consistent with the existing logic, even thoughBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI and tested manually, i.e., checked the return type.
ADDITIONAL INFORMATION