fix: Redirect on 401 #17597

geido · 2021-11-30T13:06:40Z

SUMMARY

Redirects the user to the login page when 401s responses are caught. It also passes the next_url param which is then used to redirect the user to the original page.

AFTER

DEV.Superset.1.mp4

TESTING INSTRUCTIONS

Open any page
Delete the cookies or wait for fo the auth to expire
Make an action that generates a backend request
Observe the behavior

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…e/redirect_to_login

codecov · 2021-12-06T16:52:45Z

Codecov Report

Merging #17597 (db2beac) into master (8c25f2f) will decrease coverage by 0.00%.
The diff coverage is 11.76%.

❗ Current head db2beac differs from pull request most recent head a23a886. Consider uploading reports for the commit a23a886 to get more accurate results

@@            Coverage Diff             @@
##           master   #17597      +/-   ##
==========================================
- Coverage   68.86%   68.85%   -0.01%     
==========================================
  Files        1598     1598              
  Lines       65297    65304       +7     
  Branches     6952     6953       +1     
==========================================
+ Hits        44966    44967       +1     
- Misses      18446    18451       +5     
- Partials     1885     1886       +1

Flag	Coverage Δ
javascript	`57.46% <11.76%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rc/explore/components/ExploreChartHeader/index.jsx	`46.57% <0.00%> (-0.65%)`	⬇️
superset/config.py	`91.58% <ø> (ø)`
...rset-ui-core/src/connection/SupersetClientClass.ts	`90.76% <33.33%> (-7.54%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c25f2f...a23a886. Read the comment docs.

…cubator-superset into chore/redirect_to_login

superset-frontend/packages/superset-ui-core/src/connection/callApi/parseResponse.ts

suddjian

kgabryje

Works great!
1 suggestion for a ux improvement in another PR - we should display a banner on login page that would inform user that their session expired

kgabryje · 2021-12-07T10:20:02Z

Tested 1 more scenario and I noticed that I'm not getting redirected back to the original page when I log in
EDIT: Nevermind, I forgot to rerun pip with bumped fab 🤦 After doing that, works perfectly

Screen.Recording.2021-12-07.at.11.18.50.mov

…e/redirect_to_login

* Redirect on 401 * Bump FAB * Format * Update Cypress save test * Revert Cypress change * Bump FAB 3.4.1rc2 * Update test * Update return statement * Update api test * Update datasets api test * Update datasets api 401s to 403s * Add typeguard * Use Promise.resolve * Update callApiAndParseWithhTimeout test * Disable parseResponse test * Try catch * Handle npm 8 issues (cherry picked from commit 46cdc77)

jinghua-qa · 2021-12-10T18:02:27Z

🏷️ 2021.49

Redirect on 401

f7f1fad

superset-github-bot bot added the Flexiana label Nov 30, 2021

pull-request-size bot added the size/S label Nov 30, 2021

Bump FAB

1f85890

pull-request-size bot added size/M and removed size/S labels Dec 2, 2021

Format

77ba261

pull-request-size bot added size/S and removed size/M labels Dec 2, 2021

geido marked this pull request as ready for review December 2, 2021 15:46

geido requested a review from dpgaspar December 2, 2021 15:54

geido added 2 commits December 3, 2021 14:30

Merge branch 'master' of https://github.com/apache/superset into chor…

7505763

…e/redirect_to_login

Update Cypress save test

b33ace1

pull-request-size bot added size/M and removed size/S labels Dec 3, 2021

Revert Cypress change

7a484b3

geido changed the title ~~chore: Redirect on 401~~ fix: Redirect on 401 Dec 6, 2021

Bump FAB 3.4.1rc2

b9c6d4a

pull-request-size bot added size/S and removed size/M labels Dec 6, 2021

geido added 2 commits December 6, 2021 14:49

Update test

ed06c82

Merge branch 'master' of https://github.com/apache/superset into chor…

8cc3c07

…e/redirect_to_login

pull-request-size bot added size/M and removed size/S labels Dec 6, 2021

geido and others added 4 commits December 6, 2021 15:06

Update return statement

b40daaf

Update api test

8425d46

Update datasets api test

c78ee50

Update datasets api 401s to 403s

def451d

rusackas requested a review from kgabryje December 6, 2021 17:22

rusackas requested a review from villebro December 6, 2021 17:22

geido requested a review from suddjian December 6, 2021 17:43

rusackas requested a review from mistercrunch December 6, 2021 18:05

geido added 2 commits December 6, 2021 18:50

Add typeguard

2ce7553

Merge branch 'chore/redirect_to_login' of https://github.com/geido/in…

b0a9287

…cubator-superset into chore/redirect_to_login

suddjian reviewed Dec 6, 2021

View reviewed changes

superset-frontend/packages/superset-ui-core/src/connection/callApi/parseResponse.ts Outdated Show resolved Hide resolved

geido added 2 commits December 6, 2021 19:33

Use Promise.resolve

1814d1b

Update callApiAndParseWithhTimeout test

bcec142

suddjian approved these changes Dec 6, 2021

View reviewed changes

kgabryje approved these changes Dec 6, 2021

View reviewed changes

geido added 4 commits December 7, 2021 11:37

Disable parseResponse test

dda5524

Try catch

ed51780

Merge branch 'master' of https://github.com/apache/superset into chor…

ba89e89

…e/redirect_to_login

Handle npm 8 issues

7179377

pull-request-size bot added size/L and removed size/M labels Dec 7, 2021

Merge branch 'master' of https://github.com/apache/superset into chor…

a23a886

…e/redirect_to_login

rusackas merged commit 46cdc77 into apache:master Dec 8, 2021

superset-github-bot bot added the preset:2021.49 label Dec 10, 2021

ktmud mentioned this pull request Apr 14, 2022

fix(nav): infinite redirect and upload dataset nav permissions #19708

Merged

9 tasks

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Redirect on 401 #17597

fix: Redirect on 401 #17597

geido commented Nov 30, 2021 •

edited

Loading

codecov bot commented Dec 6, 2021 •

edited

Loading

suddjian left a comment

kgabryje left a comment

kgabryje commented Dec 7, 2021 •

edited

Loading

jinghua-qa commented Dec 10, 2021

fix: Redirect on 401 #17597

fix: Redirect on 401 #17597

Conversation

geido commented Nov 30, 2021 • edited Loading

SUMMARY

AFTER

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Dec 6, 2021 • edited Loading

Codecov Report

suddjian left a comment

Choose a reason for hiding this comment

kgabryje left a comment

Choose a reason for hiding this comment

kgabryje commented Dec 7, 2021 • edited Loading

jinghua-qa commented Dec 10, 2021

geido commented Nov 30, 2021 •

edited

Loading

codecov bot commented Dec 6, 2021 •

edited

Loading

kgabryje commented Dec 7, 2021 •

edited

Loading