-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dataset): modal sql editor error #17612
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17612 +/- ##
==========================================
- Coverage 68.54% 68.39% -0.16%
==========================================
Files 1601 1602 +1
Lines 65258 65352 +94
Branches 6963 6994 +31
==========================================
- Hits 44734 44696 -38
- Misses 18634 18770 +136
+ Partials 1890 1886 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@rusackas Ephemeral environment spinning up at http://35.161.59.44:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This pr fixes the problem that when typing into the SQL editor, it always appends the old value to the end of the new value, causing it to grow exponentially.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
2021-12-01.9.21.33.mov
after
2021-12-01.9.19.38.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION