Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataset): modal sql editor error #17612

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Dec 1, 2021

SUMMARY

This pr fixes the problem that when typing into the SQL editor, it always appends the old value to the end of the new value, causing it to grow exponentially.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2021-12-01.9.21.33.mov

after

2021-12-01.9.19.38.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@stephenLYZ stephenLYZ changed the title fix(dataset): model sql editor error fix(dataset): modal sql editor error Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #17612 (c37462b) into master (2f2e8fe) will decrease coverage by 0.15%.
The diff coverage is 63.88%.

❗ Current head c37462b differs from pull request most recent head 9271265. Consider uploading reports for the commit 9271265 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17612      +/-   ##
==========================================
- Coverage   68.54%   68.39%   -0.16%     
==========================================
  Files        1601     1602       +1     
  Lines       65258    65352      +94     
  Branches     6963     6994      +31     
==========================================
- Hits        44734    44696      -38     
- Misses      18634    18770     +136     
+ Partials     1890     1886       -4     
Flag Coverage Δ
hive ?
javascript 57.14% <61.61%> (+0.07%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gacy-preset-chart-nvd3/src/DistBar/controlPanel.ts 38.46% <ø> (ø)
...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <0.00%> (ø)
...frontend/src/dashboard/components/Header/index.jsx 59.02% <ø> (ø)
...nfigModal/FiltersConfigForm/getControlItemsMap.tsx 68.18% <ø> (ø)
superset/db_engine_specs/presto.py 83.50% <ø> (-6.48%) ⬇️
...qlLab/components/EstimateQueryCostButton/index.tsx 34.48% <11.11%> (ø)
superset-frontend/src/CRUD/Field.tsx 84.21% <33.33%> (-9.54%) ⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 56.37% <37.50%> (+0.45%) ⬆️
superset/dashboards/api.py 91.86% <66.66%> (-0.29%) ⬇️
...src/filters/components/Range/RangeFilterPlugin.tsx 74.56% <75.47%> (+19.17%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2e8fe...9271265. Read the comment docs.

@stephenLYZ stephenLYZ closed this Dec 1, 2021
@stephenLYZ stephenLYZ reopened this Dec 1, 2021
@rusackas
Copy link
Member

rusackas commented Dec 1, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

@rusackas Ephemeral environment spinning up at http://35.161.59.44:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@pull-request-size pull-request-size bot added size/M and removed size/XS labels Dec 2, 2021
@rusackas rusackas merged commit b5d13d7 into apache:master Dec 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants