Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix typo on line 967 #17785

Merged

Conversation

ChristopherCFleming
Copy link
Contributor

@ChristopherCFleming ChristopherCFleming commented Dec 16, 2021

docs: correct spelling of CONTRIBUTING.MD

SUMMARY

Changed "wakeup" to "wake up" on line 967.

@AAfghahi
Copy link
Member

THis looks great, it looks like you don't have a package-lock.json. Could you add one?

if your master is up to date you could do:
git checkout master superset-frontend/package-lock.json and push that up.

@AAfghahi
Copy link
Member

Wonderful! Let me know when its all green and I will merge :)

@ChristopherCFleming
Copy link
Contributor Author

Okay. I used git checkout master superset-frontend/package-lock.json to retrieve the original file, then SKIP=check-added-large-files with this commit to disregard the file size check and push the file.

Copy link
Member

@AAfghahi AAfghahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a summary?

@AAfghahi AAfghahi merged commit 4beaa81 into apache:master Dec 17, 2021
@eschutho eschutho added the Superset-Community-Partners Preset community partner program participants label Jan 5, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* Line 976 was wakeup, now wake up

* Removed package lock to test environment

* Return original package-lock.json
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* Line 976 was wakeup, now wake up

* Removed package lock to test environment

* Return original package-lock.json
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS Superset-Community-Partners Preset community partner program participants 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants