Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): bump broken packages #17800

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Conversation

villebro
Copy link
Member

@villebro villebro commented Dec 17, 2021

SUMMARY

A dependency of the node-sass package (node-gyp) was so old it was crashing npm i, thus blocking the docs CI workflow. This PR bumps the node-sass version to a fairly recent one, along with gatsby-plugin-sass which also needed to be bumped. Also bumps the lock file to version 2.

SCREENSHOT

To ensure the new build works, running npm run start starts the local server properly:
image

TESTING INSTRUCTIONS

run the following in your terminal:
cd docs && npm i && npm run start

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit f396818 into apache:master Dec 17, 2021
@villebro villebro deleted the villebro/docs-ci branch December 17, 2021 13:44
@villebro villebro mentioned this pull request Dec 17, 2021
9 tasks
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants